Noticed this was a frozen interface only after writing the patch. Guess this is a Moz2 kind of thing then?

New things should go to nsIDOMNSHTMLLinkElement interface.

Comment on attachment 326656 [details] [diff] [review] Patch Yeah, either wait for Moz2 (and re-request reviews then), or create a new nsIDOMNSHTMLLinkElement interface that extens nsIDOMHTMLLinkElement and adds this property.

Let's try that again with the new interface actually included in the diff this time...

Comment on attachment 343496 [details] [diff] [review] Patch v2.1 >+[scriptable, uuid(ea4e4325-9cc4-42ac-8126-0a8c035c165a)] >+interface nsIDOMNSHTMLLinkElement : nsISupports >+{ >+ attribute DOMString sizes; >+}; Make nsIDOMNSHTMLLinkElement inherit nsIDOMHTMLLinkElement and then nsHTMLLinkElement should inherit only nsIDOMNSHTMLLinkElement. That way you don't increase the size of the nsHTMLLinkElement (doesn't increase vtable).

Comment on attachment 343496 [details] [diff] [review] Patch v2.1 New patch coming?

New patch, taking advantage of the now non-frozen interfaces to simply add the sizes attribute to nsIDOMHTMLLinkElement

Comment on attachment 480372 [details] [diff] [review] new patch You should update the iid of the interface. And where is the test?

Addressing issues from comment 9

Sorry, I had not hg added the test case.

The IDL attribute shouldn't be a DOMString but a DOMSettableTokenList. By the way, if you just need .sizes done this way (a simple reflection of the content attribute), you can use .getAttribute('sizes') for the moment and change that when .sizes will be implemented.

Comment on attachment 480604 [details] [diff] [review] corrected patch Mounir is very true. .sizes isn't a DOMString, but DOMSettableTokenList. Unfortunately the current HTML5 draft has [PutForwards=value] - I think we should get rid of that. Want to sent question to whatwg why Hixie has used PutForwards (which is generally an indicator of an ugly API, IMHO)?