Closed Bug 44186 Opened 24 years ago Closed 24 years ago

[view-source] xul files containting <script .../> gain a </script>

Categories

(Core :: DOM: HTML Parser, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: timeless, Assigned: harishd)

References

()

Details

Attachments

(1 file)

2000062708 win32talkback and confirmed w/ various other builds from this week. cvs build from about 2 hours ago on rh6.2 linux 1. load url. 2. view-source 3. notice <script.../></script> 4. find a text editor or something similar (or use mozilla to view the lxr source for this file) 5. notice </script> is not part of the file. Additional comments: this happens with lots of files. I don't know anything about dtd, but I do not want this bug closed because of dtd. If you think that it's a dtd issue please upload a testcase w/ a correct dtd showing how to workaround this problem. And once you've done that, I think we need a patch in mozilla anyways, because this is standard practice and afaik no one objected.
Harish, I'm reassigning rickg parser bugs to you.
Assignee: rickg → harishd
In view source a valid XML tag is becoming invalid. Nominating for nsbeta3.
Status: NEW → ASSIGNED
Keywords: nsbeta3
Target Milestone: --- → M18
This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.
Target Milestone: M18 → Future
Marking nsbeta3-
Whiteboard: [nsbeta3-]
That's real nice. removing nsbeta3-. I object to this bug being futured. If the netscape engineer would please attach whatever information maybe helpwanted from mozilla.org would work. Adding keyword soup. view-source is supposed to view source. Parser should not touch it. I know we all love to abuse parser but I don't think that this should happen [adding arch]. Hixie, help for correctness, maybe you can light a fire and get this fixed... scc, could you find out where this bug could be moved? thanks.
OS: Windows 2000 → All
Hardware: PC → All
Whiteboard: [nsbeta3-] → [HIXIE-HELP]
timeless: Woha. If you want this fixed, please look through all the other bugs Harish has to fix by nsbeta3 and tell us which one should be minused instead. Harish already has 8 nsbeta3+ bugs and at this point he should only have about 6 if he is to get them all fixed by beta3 release. Compared to the other bugs on his plate, an error on the View Source page is negligable, IMHO.
Keywords: arch
Whiteboard: [HIXIE-HELP]
Marking nsbeta3- based on priorities.
Whiteboard: [nsbeta3-]
View source on this file now shows up blank.
Whiteboard: [nsbeta3-] → [nsbeta3-][rtm-]
Marking rtm-. Harish will investigate the blank view-source problem further and open a bug if needed.
chrome: causes view-source to render blank. With 'file:', however, view-source does render the document. That is, save the above file locally and load it with file:. Now, you should be able to view-source.
Blocks: 57724
Is this important enough to merit a release note? Or was relnote merely added in timeless' irate period? ;-) The blurb: It seems unclear to me whether this bug requires either of a "developer" or "user" release note for Netscape 6 RTM. If anyone feels it does, can they please draft one and then nominate with the relnote-user or relnote-devel strings in the Status Whiteboard. Thanks :-) Gerv
If this gets a relnote, the other bugs blocking the tracking bug 57724 should also get relnotes. (Or maybe there should just be one note saying "view-source sometimes munges invalid pages" with a list of causes.)
um, you mean view-source munges _valid_ xml pages. relnote-developer: Don't use view-source to debug chrome, it munges xml. There is no current workaround, if this irks you please fix it.
Whiteboard: [nsbeta3-][rtm-] → [nsbeta3-][rtm-] relnote-developer
Oops, I looked at this bug too quickly. Thanks for the correction. You have to be more creative with workarounds, though. For example: save the page, and then open the page with a text editor that can handle various newline encodings.
Changing relnote-developer to relnote-devel for consistency.
Whiteboard: [nsbeta3-][rtm-] relnote-developer → [nsbeta3-][rtm-] relnote-devel
Target Milestone: Future → mozilla0.9
Nominating for nsbeta1 consideration. Obviously we could leave this as-is and still ship the next release (heck, we *could* leave it this way *forever* as this doesn't impact the ordinary consumer user) but this is one of those annoying glitches that gets in developers' way on a daily basis if they're using XUL, so it would be good to fix it for their benefit.
Keywords: nsbeta1
I'm not able to view source the above URL anymore! ( all I get is a blank window ). Anyone else?
don't blame me. let's blame jag
Keywords: nsbeta3, rtm
Whiteboard: [nsbeta3-][rtm-] relnote-devel → relnote-devel
Jag: Any input on why it's not possible to view-source the above URL?
On Windows, I'd guess bug 66034. On any other platform, I don't know (yet).
I don't think it's bug 66034, because it's still blank if I resize the window. (Actually, if I make the window bigger, part of the window is transparent.)
I don't think we need a xul file to reproduce the problem. The following snippet should be sufficient: <html> <head> <script/> </head> </html>
Attached patch proposed patch v1.1 (deleted) — Splinter Review
Whiteboard: relnote-devel → [fix in hand] relnote-devel
The indentation in the end of the while seems weird. Tabs maybe, can you fix it? Other than that, r=heikki.
Hmm...it sounds like view source for XML documents is currently going through the HTMLTokenizer and that seems wrong. Changing this should do the right thing for XML and XUL documents. I'm not convinced it's necessary to correctly deal with the XML syntax for empty elements in HTML documents, though.
Well, I do think we need to deal with (at least some) XML constructs in HTML as long as it is possible to pass XHTML documents through the HTML parser etc. But I agree that it would be better to fix XML documents to use XML source path for view source as well...
I spoke with Vidur and he's ok with landing the change to support XHTML documents. Also, I have the patch to select the appropriate tokenizer based on mimetype in the view-source dtd. But have to do more testing on it. Will be landing the above patch anyway.
updated qa contact.
QA Contact: janc → bsharma
fix is in. Marking FIXED.
Marking FIXED for real :)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
vrfy !!! w32 3/8-04 data:text/xml,<html><script/></html> and data:text/xul,<window><script/></window>
Status: RESOLVED → VERIFIED
Whiteboard: [fix in hand] relnote-devel
No longer blocks: 57724
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: