Closed Bug 44208 Opened 24 years ago Closed 24 years ago

Need notification of going offline

Categories

(Core :: Networking, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED
mozilla0.8

People

(Reporter: Bienvenu, Assigned: alecf)

References

Details

(Keywords: arch, Whiteboard: fix in hand)

Attachments

(2 files)

I need notification of when the user toggles the offline button so I can shut down open connections to imap servers and news servers. I know I can query the offline state, but what I need is a notification. If the right way to do this is to add methods to nsIOService to register interest in offline state changes, I can add that myself and get a code review from a necko person. Please let me know one way or the other.
Adding gordon to cc list since he seems to have change the offline code a little bit. I'm mainly for guidance here; I'm willing to do the work if you guys can't do it.
Perhaps we can associate an nsIObserverList with nsIIOService and allow people to register nsIObservers (although I think nsIObserver needs a little work).
Target Milestone: --- → Future
Bienvenu, is this still a concern of yours? Has any work been done on this bug? thx.
it is about to be a huge concern of mine going forward as we start to do offline mail and news. No work has been done, AFAIK.
added keyword arch.
Keywords: arch
Blocks: 61689
nominating for nsbeta1.
Keywords: nsbeta1
bienvenu: nsIObservers are working well now, right? if so, then this is probably the correct implementation... are you going to be submitting a patch for this?
I have no idea why Warren said nsIObservers needed work, so I don't know if his concern(s) were addressed. I can try to attach a patch for this.
reassigning to me - I need this in the browser, and it was easier just to implement this than debate about it :) I could use a review/super review...
Assignee: gagan → alecf
Status: NEW → ASSIGNED
Whiteboard: fix in hand
adding dependancy, resetting milestone
Blocks: 65704
Target Milestone: Future → mozilla0.8
r=valeski if you (void) the return value of the Notify() calls. If you don't care about return values, make it explicit, otherwise I think you're just dropping error codes.
done in my local tree (along with a comment to this effect) still need an sr=.. bienvenu?
sure, sr=bienvenu
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
thanks guys, fix is in.
Attached patch fix random crashing on shutdown (deleted) — Splinter Review
sr=bienvenu
QA Contact: tever → bbaetz
Patches checked in, according to LXR. VERIFYING
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: