Closed
Bug 44208
Opened 24 years ago
Closed 24 years ago
Need notification of going offline
Categories
(Core :: Networking, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla0.8
People
(Reporter: Bienvenu, Assigned: alecf)
References
Details
(Keywords: arch, Whiteboard: fix in hand)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
I need notification of when the user toggles the offline button so I can shut
down open connections to imap servers and news servers. I know I can query the
offline state, but what I need is a notification. If the right way to do this is
to add methods to nsIOService to register interest in offline state changes, I
can add that myself and get a code review from a necko person. Please let me
know one way or the other.
Reporter | ||
Comment 1•24 years ago
|
||
Adding gordon to cc list since he seems to have change the offline code a little
bit. I'm mainly for guidance here; I'm willing to do the work if you guys can't
do it.
Comment 2•24 years ago
|
||
Perhaps we can associate an nsIObserverList with nsIIOService and allow people
to register nsIObservers (although I think nsIObserver needs a little work).
Comment 3•24 years ago
|
||
Bienvenu, is this still a concern of yours? Has any work been done on this bug?
thx.
Reporter | ||
Comment 4•24 years ago
|
||
it is about to be a huge concern of mine going forward as we start to do offline
mail and news. No work has been done, AFAIK.
Comment 7•24 years ago
|
||
bienvenu: nsIObservers are working well now, right? if so, then this is
probably the correct implementation... are you going to be submitting a
patch for this?
Reporter | ||
Comment 8•24 years ago
|
||
I have no idea why Warren said nsIObservers needed work, so I don't know if his
concern(s) were addressed. I can try to attach a patch for this.
Assignee | ||
Comment 9•24 years ago
|
||
Assignee | ||
Comment 10•24 years ago
|
||
reassigning to me - I need this in the browser, and it was easier just to
implement this than debate about it :)
I could use a review/super review...
Assignee: gagan → alecf
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Whiteboard: fix in hand
Assignee | ||
Comment 11•24 years ago
|
||
adding dependancy, resetting milestone
Blocks: 65704
Target Milestone: Future → mozilla0.8
Comment 12•24 years ago
|
||
r=valeski if you (void) the return value of the Notify() calls. If you don't
care about return values, make it explicit, otherwise I think you're just
dropping error codes.
Assignee | ||
Comment 13•24 years ago
|
||
done in my local tree (along with a comment to this effect)
still need an sr=.. bienvenu?
Reporter | ||
Comment 14•24 years ago
|
||
sure, sr=bienvenu
Assignee | ||
Updated•24 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 15•24 years ago
|
||
thanks guys, fix is in.
Assignee | ||
Comment 16•24 years ago
|
||
Reporter | ||
Comment 17•24 years ago
|
||
sr=bienvenu
Comment 18•23 years ago
|
||
Patches checked in, according to LXR. VERIFYING
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•