Closed
Bug 442358
Opened 16 years ago
Closed 16 years ago
jsinterp control flow doesn't flow as specified
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: mrbkap)
References
Details
(Keywords: fixed1.9.0.2)
Attachments
(1 file)
|
(deleted),
patch
|
igor
:
review+
samuel.sidler+old
:
approval1.9.0.2+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/js/src/jsinterp.cpp#5200 is a return statement and there is another one a few lines down.
This breaks the rule that code most flow through exit2 at http://mxr.mozilla.org/mozilla-central/source/js/src/jsinterp.cpp#2718
|
||
Updated•16 years ago
|
Flags: wanted1.9.1?
|
Assignee | |
Comment 1•16 years ago
|
||
|
||
Updated•16 years ago
|
Attachment #328463 -
Flags: review?(igor) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Pushed as changeset 32207c9fccb6.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
Flags: wanted1.9.1? → wanted1.9.1+
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 328463 [details] [diff] [review]
Obvious patch
I'm guessing we want this in 1.9.
Attachment #328463 -
Flags: approval1.9.0.2?
|
||
Comment 4•16 years ago
|
||
Comment on attachment 328463 [details] [diff] [review]
Obvious patch
Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #328463 -
Flags: approval1.9.0.2? → approval1.9.0.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•