Closed
Bug 442484
Opened 16 years ago
Closed 16 years ago
packager.mk doesn't work correctly with non-default topsrcdir
Categories
(Toolkit Graveyard :: Build Config, defect)
Toolkit Graveyard
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
In http://hg.mozilla.org/users/kairo_kairo.at/index.cgi/calemaisu-test/file/f3a0dcddc05c/suite/locales/Makefile.in#l158 (same for installer and the mail pendents), we're calling toolkit's packager.mk so that we don't need separate copies of those toolkit files in our repository.
Because of this, http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#41 fails as the topsrcdir is not the mozilla-central directory in that case.
We can work around that pretty easily by using MOZILLA_DIR, which is set by rules.mk and can be set by our own rules.mk accordingly.
|
Assignee | |
Comment 1•16 years ago
|
||
This works fine with Firefox/Minefield from mozilla-central as well as SeaMonkey from the test repo.
|
|
Assignee | |
Comment 2•16 years ago
|
||
There's more that needs that change in packager.mk
Summary: packager.mk doesn't find package-name.mk with non-default topsrcdir → packager.mk doesn't work correctly with non-default topsrcdir
|
|
Assignee | |
Comment 3•16 years ago
|
||
Sorry for not having all this in the first patch, but I didn't actually doing a package before. With this patch, even creating a package works.
Attachment #327263 -
Attachment is obsolete: true
Attachment #327291 -
Flags: review?(ted.mielczarek)
Attachment #327263 -
Flags: review?(ted.mielczarek)
|
||
Updated•16 years ago
|
Attachment #327291 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
fixed in changeset 8391ac1437ef
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•