Closed
Bug 442802
Opened 17 years ago
Closed 11 years ago
Port rdf-templated search widgets to js
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 878604
People
(Reporter: jminta, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
Bienvenu
:
review-
Bienvenu
:
superreview-
|
Details | Diff | Splinter Review |
The only remaining rdf widgets for folders/accounts (other than the folder pane and the account settings tree) are the tree-style pickers defined in mailWidgets.xml. This patch switches them to be js-driven. It unfortunately ended up being more verbose than I would have liked, mostly due to a lack of easy to use APIs for getting things like sorted folders/accounts and the list of recent folders. Obviously we should work toward changing that, but getting rid of rdf is still a higher priority for me.
Attachment #327504 -
Flags: superreview?(bienvenu)
Attachment #327504 -
Flags: review?(bienvenu)
Comment 1•17 years ago
|
||
some quick comments:
this patch didn't apply cleanly for mail/base/content/SearchDialog.xul - I had to apply it by hand.
For generate_unread, we don't want to include Junk or Trash folders.
Is the plan that eventually the folder pane will use this widget?
I've applied this patch and am running with it.
When I tried the advanced search dialog, the folder picker's scroll bar didn't work - clicking anywhere in the scroll bar dismissed the menu. The cursor keys didn't do anything either.
Comment 2•17 years ago
|
||
Comment on attachment 327504 [details] [diff] [review]
patch v1
minusing based on bugs encountered w/ patch.
Attachment #327504 -
Flags: superreview?(bienvenu)
Attachment #327504 -
Flags: superreview-
Attachment #327504 -
Flags: review?(bienvenu)
Attachment #327504 -
Flags: review-
Updated•12 years ago
|
Assignee: jminta → nobody
Status: ASSIGNED → NEW
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Updated•11 years ago
|
No longer blocks: mail-killrdf
You need to log in
before you can comment on or make changes to this bug.
Description
•