Steps of reproduce 1. Open Composer 2. Select File|Sava As Charset and open dialog title is "Save As Charset" 3. select UTF-8(or any charset) 4. *Not* enter in page title. (makes blank) 5. select OK dialog title is changed, and displayed with garbage. I tested with BuildID:20000062920 on WinNT4/SP5.

Reproducible, reassign to editor group.

This does not happen in 2000-06-30-08 Win32 build.

I am sorry, I did not click OK button. I could reproduce it. This is related to the bug 40739.

assigning this over to jfrancis

umm, this should be cmanske or ftang, it appears, given the checkin history to EditorSaveAsCharset.js. bumping over to Charlie for disposition...

I don't see any problem here -- Frank just checked in fix for 40739 today, so maybe this is a dup of that problem. I'll let ftang confirm this.

Please do not assign "Save As Charset" bug to editor group. It is my code and I don't want to wast cmanske's time until I really need their help. teruko, can you try to reproduce it again ?

Mark this as fix. I believe this is fixed while I fix 40739. Please reopen it if it still happen.

I tested this in 2000-08-25-08 Win32 build. This still happen. Reopenning..

Changed QA contact to ylong@netscape.com.

reassign this bug to yokoyama. Mark it as Moz 0.9 P3.

I did see this in 01-16 Mtrunk build.

Reassign to jbetak. ylong, please test with the latest build.

I didn't see it on 03-27 Win32 trunk build(cause the other 2 platform builds not avalible at this point) and 03-16/19 Linux and Mac trunk build.

This still happens. As per nhotta's assignment (2001-03-27 10:46), I am assign this to jbetak. It looks though the assignment never took place.

accepting, targeting 0.9.2

looks like editorShell.SetDocumentTitle was setting the title for both the parent and the charset dialog window. I moved it into ComposerCommands.js and while at it I also refactored some (seemingly random) bits of code ... nhotta (yokoyama): would you care to review?

The code in ComposerCommands.js is non specific to saveascharset, right? Does you change affects others (e.g. save, saveas)?

Naoki, this affects SaveAsCharset only. I copied the whole code section below for easier verification: var nsSaveAsCharsetCommand = { isCommandEnabled: function(aCommand, dummy) { return (window.editorShell && window.editorShell.documentEditable); }, doCommand: function(aCommand) { FinishHTMLSource(); window.ok = false; window.exportToText = false; window.openDialog ("chrome://editor/content/EditorSaveAsCharset.xul","_blank", "chrome,close,title bar,modal,resizable=yes"); if (window.newTitle != null) { try { editorShell.SetDocumentTitle(window.newTitle); } catch (ex) {} } if (window.ok) { if (window.exportToText) { window.ok = window.editorShell.saveDocument(true, true, "text/plain"); } else { window.ok = window.editorShell.saveDocument(true, false, editorShell.contentsMIMEType); } } window._content.focus(); return window.ok; } };

r=nhotta

Since this is not moz0.9.2 critical, move it to moz0.9.3. cmanske- this is under your code. please review it. thanks.

add cmanske to the cc list.

r=cmanske Looks good!

cmanske: thanks for taking time to review this! adding alecf for sr= and blizzard for a=

sr=alecf

a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)

checked in

checked in

Naoki, thanks for helping to obtain the sr=, a= and for landing this!

Verified on 06-15-06 trunk build.