User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0 Build Identifier: 0.2.0 My suggestion is to have a single option in Weave's preferences that allows Weave to treat remote and local tab restoration the same. Currently, the user must turn on 'Show my windows and tabs from last time' in order to restore tabs locally on one machine. This behavior prevent the closing of tabs remotely. Example: 1. Open 4 tabs at home, close and sync. 2. If I go to work and restore the 4 tabs I had from home, close 3 of the 4 tabs. 3. If I then go home, those same 4 tabs will restore even those I purposefully closed them from work. Reproducible: Always Steps to Reproduce: 1. 2. 3.

This could have very disconcerting effects if someone else closes a tab on a browser you left open. It might delete them while you are browsing. Perhaps if the deletion behavior is limited to startup, it might be ok. Cc'ing Myk for comments.

I do agree that there's a use case for a roaming session that follows you from computer to computer, but it's not the only use case, so while it would be worthwhile to implement it, we should do so in a way that doesn't require that behavior.

Myk, any other suggestions for alternate behavior that would create roaming sessions (tabs). If the user does not enable 'Show my windows and tabs from last time', then there is no need to delete tabs (from Dan's comment) IF Weave did the restoration itself locally regardless of the the last sync being from a remote or local computer. If the user did have 'Show my windows and tabs from last time', that's where the problems would start. Maybe a single option in preferences (off by default) called, "Ignore 'Firefox's Show my windows and tabs from last time'" which would restore tabs locally regardless of FF options producing double tabs in some cases.

(In reply to comment #3) > Maybe a single option in preferences (off by default) called, "Ignore > 'Firefox's Show my windows and tabs from last time'" which would restore tabs > locally regardless of FF options producing double tabs in some cases. One way to resolve the inconsistency is to turn off "show my windows and tabs from last time" when the user enables "restore my session from other computers" (or whatever we call the Weave preference for automatically restoring your saved Weaved session on each computer you connect to Weave). But that seems unnecessary. I think this feature is not particularly complicated to implement. If a user wants their session to follow them from computer to computer, and they enable that option, and "show my windows and tabs from last time" is also enabled on one or more of those computers, then Weave might indeed close some of their tabs on startup. But that's what the user said they wanted, so it seems like a reasonable thing to do (even in the middle of the session, if the user is using two computers simultaneously). And if they miss those tabs, they can always get them back from the Recently Closed Tabs menu. Of course, I wouldn't suggest enabling this preference by default. But it seems like it should be possible to make it available for users who want this behavior without worrying too much about tabs getting deleted. But maybe I am not understanding the concern.

How about we present tab deletions in the notification, as well as tabs to add? I'm not sure what the design would look like, but I think it could solve this problem without any new prefs.

Hmm, that doesn't sound like the right solution. For users who want a roaming session, it would be more work to use the notification to retrieve it on every startup. And for users who don't want a roaming session, it would be more work to navigate the tab deletion UI when using the notification. The functionality requested by this bug seems to me to be a fundamentally different use case from the one for which we designed the current UI. It's a valid use case, nonetheless, so it would be good to support it. But I don't think the notification is the way to do it. However, we could use the notification to make the functionality more discoverable. For example, we could add a checkbox to the notification to "always restore my tabs". We would just have to make sure to word it so it's clear that the option will also remove tabs (perhaps "keep my tabs synced across computers"?). Alternately, we could have two options, one that only adds tabs and another that also removes them (f.e. something like "always restore my tabs" and "remove tabs I closed on another computer"), but that starts to get overcomplex. Note: if we did have a preference for this, we might add it as an option to the "When Firefox starts" dropdown menu in the Main pane of the preferences dialog instead of (or in addition to) the Weave pane, f.e. something like "Show my tabs from my last computer".

These are all fantastic ideas. Making the process of "roaming sessions" more seamless and transparent will be helpful. I like the idea and would use the option, but adding this in the "When Firefox starts" might make it harder to find for the casual Weave user looking for "roaming sessions". Although, maybe the casual user isn't interested in this to begin with?

The way tabs are synced now is very different, and this isn't valid/relevant to that.