Closed
Bug 444021
Opened 16 years ago
Closed 15 years ago
Remove useless |#include "nsILocale[Service|].h"|
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla1.9.2b1
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
While working on bug 311672, I noticed (and removed)
{{
/toolkit/components/places/src/nsNavHistoryResult.cpp
* line 55 -- #include "nsILocaleService.h"
}}
It looks like a few other files might uselessly include this file too.
Someone (with a compiler) should check/test this.
NB: Probably, check |#include "nsILocale.h"| too...
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [good first bug]
|
|
Assignee | |
Comment 1•15 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090806 SeaMonkey/2.1a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/5c913c4662d8 + bug 444021 patch
+http://hg.mozilla.org/comm-central/rev/4344cc9a28a7)
Assignee: smontagu → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #392948 -
Flags: review?(smontagu)
|
|
Assignee | |
Updated•15 years ago
|
Flags: in-testsuite-
Summary: Remove (supposed) useless |#include "nsILocaleService.h"| !? → Remove useless |#include "nsILocale[Service|].h"|
Whiteboard: [good first bug]
|
||
Comment 2•15 years ago
|
||
Comment on attachment 392948 [details] [diff] [review]
(Av1) Just remove them
[Checkin: Comment 3]
r=me assuming that it compiles
Attachment #392948 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Comment on attachment 392948 [details] [diff] [review]
(Av1) Just remove them
[Checkin: Comment 3]
http://hg.mozilla.org/mozilla-central/rev/d6a04f1f8a74
(In reply to comment #2)
> r=me assuming that it compiles
My local build was a clobber, this is expected to be fine on tinderboxes too...
Attachment #392948 -
Attachment description: (Av1) Just remove them → (Av1) Just remove them
[Checkin: Comment 3]
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
You need to log in
before you can comment on or make changes to this bug.
Description
•