Closed
Bug 445374
Opened 16 years ago
Closed 16 years ago
In </browser/*>, "use a xul <stringbundle/> instead of including the strres.js code"
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3.1a2
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(2 files)
|
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
tony
:
review+
Gavin
:
review+
|
Details | Diff | Splinter Review |
{{
/browser/base/content/pageinfo/pageInfo.xul
* line 73 -- <script type="application/x-javascript" src="chrome://global/content/strres.js"/>
/browser/components/safebrowsing/content/blockedSite.xhtml
* line 60 -- <script type="application/javascript" src="chrome://global/content/strres.js"/>
}}
|
Assignee | |
Updated•16 years ago
|
|
|
Assignee | |
Comment 1•16 years ago
|
||
Simple copy of SM bug 445387 patch Bv1.
|
|
Assignee | |
Updated•16 years ago
|
Attachment #331540 -
Flags: review? → review?(mano)
|
|
Assignee | |
Updated•16 years ago
|
Flags: in-testsuite-
Target Milestone: --- → Firefox 3.1a2
|
||
Comment 2•16 years ago
|
||
Comment on attachment 331540 [details] [diff] [review]
(Av1) </browser/base/content/pageinfo/*>
[Checkin: Comment 3]
r=mano
Attachment #331540 -
Flags: review?(mano) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: Av1 // Leave opened]
|
||
Comment 3•16 years ago
|
||
attachment 331540 [details] [diff] [review] landed on trunk: http://hg.mozilla.org/index.cgi/mozilla-central/rev/a7ae1325476b
Keywords: checkin-needed
|
|
Assignee | |
Updated•16 years ago
|
Attachment #331540 -
Attachment description: (Av1) </browser/base/content/pageinfo/*> → (Av1) </browser/base/content/pageinfo/*>
[Checkin: Comment 3]
|
|
Assignee | |
Comment 4•16 years ago
|
||
Callers were removed by
<http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/browser/components/safebrowsing/content/blockedSite.xhtml&mark=1.3>
but
<https://bugzilla.mozilla.org/show_bug.cgi?id=402370>
is "You are not authorized to access bug #402370." to me.
Attachment #331678 -
Flags: review?(madajt)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #331678 -
Flags: review?(madajt) → review?(tony)
|
||
Comment 5•16 years ago
|
||
Comment on attachment 331678 [details] [diff] [review]
(Bv1) <blockedSite.xhtml>
[Checkin: Comment 7]
Adding johnath since he was the last to touch this code.
Attachment #331678 -
Flags: review?(tony)
Attachment #331678 -
Flags: review?(johnath)
Attachment #331678 -
Flags: review+
|
|
Assignee | |
Comment 6•16 years ago
|
||
Comment on attachment 331678 [details] [diff] [review]
(Bv1) <blockedSite.xhtml>
[Checkin: Comment 7]
johnath doesn't seem to be around...
Attachment #331678 -
Flags: review?(gavin.sharp)
|
||
Updated•16 years ago
|
Attachment #331678 -
Flags: review?(johnath)
Attachment #331678 -
Flags: review?(gavin.sharp)
Attachment #331678 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: Av1 // Leave opened] → [c-n: Bv1]
|
|
||
Comment 7•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: Bv1]
|
|
Assignee | |
Updated•16 years ago
|
Attachment #331678 -
Attachment description: (Bv1) <blockedSite.xhtml> → (Bv1) <blockedSite.xhtml>
[Checkin: Comment 7]
You need to log in
before you can comment on or make changes to this bug.
Description
•