Closed
Bug 445518
Opened 16 years ago
Closed 16 years ago
snav: impossible to open <select name="dropdown"> widget
Categories
(Toolkit Graveyard :: Spatial Navigation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wildriding, Assigned: dougt)
References
Details
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a1pre) Gecko/2008071610 Minefield/3.1a1pre
Build Identifier:
simple testcase attached
Reproducible: Always
Steps to Reproduce:
1. select dropdown list on the page
2. try to open it (logicaly should be ENTER)
Actual Results:
nothing happened
Expected Results:
dropdown list opened
|
Reporter | |
Comment 1•16 years ago
|
||
|
Assignee | |
Comment 2•16 years ago
|
||
Assignee: nobody → doug.turner
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #329872 -
Flags: review?(gavin.sharp)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 329872 [details] [diff] [review]
patch v.1
>diff --git a/toolkit/spatial-navigation/SpatialNavigation.js b/toolkit/spatial-navigation/SpatialNavigation.js
>+ if (event.keyCode == event.DOM_VK_DOWN ) {
>+ if (event.target.length - event.target.selectedIndex != 1)
uber-nit (because I know you love them so much): I find this easier to read with the selectedIndex on the other side of the comparison
might also be nice to put event.target in a local variable given the number of times it's referred to.
Attachment #329872 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
the attached mochitest fails during automation. I think it is due to the test harness adding extra "targetable" areas in the <body>. Need to investigate.
|
|
Assignee | |
Comment 5•16 years ago
|
||
fd1c0f6abf6d
(the test case was fixed by using timeouts.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 6•16 years ago
|
||
Now it's possible to focus select element and go through options and that's nice BUT how about drop-down behavior. For now drop-down list doesn't look like drop-down.
Is this target behavior?
|
|
Assignee | |
Comment 7•16 years ago
|
||
antonr, that is a separate bug. feel free to file it, or I can.
Blocks: 1243213
|
||
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•