Closed
Bug 445741
Opened 16 years ago
Closed 16 years ago
box-shadow: small transparent gap between box and shadow
Categories
(Core :: Web Painting, defect)
Core
Web Painting
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: phiw2, Assigned: ventnor.bugzilla)
References
()
Details
(Keywords: testcase, verified1.9.1)
Attachments
(6 files, 1 obsolete file)
|
(deleted),
text/html
|
Details | |
|
(deleted),
text/html
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
application/xhtml+xml
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
screenshot, testcase 1
Randomly, a small transparent gap appears between a box an its shadow. This is more visible when width and or height compute to some fraction of pixels, or when height depends on line-height/font-size.
On OS X 10.5 it happens more often, but I've seen this on linux/Ubuntu as well.
Zooming in (text or page zoom) makes the gap appear or disappear.
Testcase 1 uses width:50.3px; height:100.3px;
|
Reporter | |
Comment 1•16 years ago
|
||
test case is affected by font-size/line-height (1em/normal)
zoom in or out makes the gap appear/disappear.
|
|
Reporter | |
Comment 2•16 years ago
|
||
testcase 1 on OS X 10.5.4
|
||
Comment 3•16 years ago
|
||
Probably related to the code that decides whether to pixel-snap or not; we don't pixel-snap anymore during zoom.
Component: Style System (CSS) → Layout: View Rendering
QA Contact: style-system → layout.view-rendering
I ran into it as well. Attached is a reduced version of page I encountered it on.
|
||
Comment 5•16 years ago
|
||
As you can see on attachment 337022 [details] (bug 453641) this doesn't happen for table.
|
||
Comment 6•16 years ago
|
||
Not sure whether this is the same case but I observe a gap on the right side of the border just before the shadow of some popup menus.
|
Assignee | |
Comment 7•16 years ago
|
||
The first testcase has decimal values for pixels, so the frame is rounded but our cliprect (made from the frame rect) is not. This patch fixes all the testcases for me.
Attachment #355323 -
Flags: superreview?(roc)
Attachment #355323 -
Flags: review?(roc)
|
|
Assignee | |
Comment 8•16 years ago
|
||
This adds reftests.
Attachment #355323 -
Attachment is obsolete: true
Attachment #355332 -
Flags: superreview?(roc)
Attachment #355332 -
Flags: review?(roc)
Attachment #355323 -
Flags: superreview?(roc)
Attachment #355323 -
Flags: review?(roc)
Attachment #355332 -
Flags: superreview?(roc)
Attachment #355332 -
Flags: superreview+
Attachment #355332 -
Flags: review?(roc)
Attachment #355332 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
Pushed 7c9c52594a4b.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing] → [needs 191 approval]
Attachment #355332 -
Flags: approval1.9.1?
Comment on attachment 355332 [details] [diff] [review]
Patch 2
Safe fix for a bug in a new feature.
|
|
||
Comment 11•16 years ago
|
||
Verified with:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090106 Minefield/3.2a1pre ID:20090106020453
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090106 Minefield/3.2a1pre ID:20090106034601
Target Milestone: --- → mozilla1.9.2a1
|
|
||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
|
||
Comment 12•16 years ago
|
||
Comment on attachment 355332 [details] [diff] [review]
Patch 2
a191=beltzner
Attachment #355332 -
Flags: approval1.9.1? → approval1.9.1+
Keywords: checkin-needed
Whiteboard: [needs 191 approval] → [needs 191 landing]
Assignee: nobody → ventnor.bugzilla
Pushed 8a71bb3b0790 to 1.9.1
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs 191 landing]
|
|
||
Comment 14•16 years ago
|
||
Verified on 1.9.1 with:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090129 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090129021345
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre ID:20090129033611
Flags: in-litmus-
Keywords: fixed1.9.1 → verified1.9.1
|
||
Updated•6 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•