Closed
Bug 445768
Opened 16 years ago
Closed 16 years ago
CTRL+Tab moves to location bar if only 1 tab is open.
Categories
(Firefox :: Keyboard Navigation, defect)
Firefox
Keyboard Navigation
Tracking
()
VERIFIED
FIXED
Firefox 3.1a2
People
(Reporter: MarcoZ, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
STR:
1. Open Firefox 3.1a1pre.
2. Open a single page, make sure no other tabs are open.
3. Press Ctrl+Tab.
Expected: Nothing happens.
Actual: Focus is moved to the Location bar.
|
Assignee | |
Updated•16 years ago
|
Blocks: 395980
Keywords: regression
|
||
Comment 2•16 years ago
|
||
Pressing Ctrl+Tab then disables the F6 cycling, as seen in this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=426850
1. Press Ctrl+Tab with 1 window open.
It seems Ctrl+Tab acts the same as F6 and thus gets stuck after moving from frame 1 to frame 2. Possibly related?
Confirmed on Windows.
Regression range is between:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008071504 Minefield/3.1a1pre
and
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008071603 Minefield/3.1a1pre
Hasham, can you find the regression between hourly builds between those nightly builds? Just to narrow it down, also if you could post the link with the checkins between then, that would be great.
Kurt, I couldn't access hourly builds on 7/15 because ftp://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/ only gives builds from the past two days. I'm not aware of any hourly build archives so I couldn't really tell you a more specific time frame than that. Sorry :(
|
|
Assignee | |
Comment 6•16 years ago
|
||
Bug 395980 caused this.
|
|
Assignee | |
Comment 7•16 years ago
|
||
trivial fix
|
||
Updated•16 years ago
|
Attachment #333295 -
Flags: review?(gavin.sharp) → review+
|
|
||
Comment 8•16 years ago
|
||
Comment on attachment 333295 [details] [diff] [review]
patch
>diff --git a/browser/base/content/test/browser_ctrlTab.js b/browser/base/content/test/browser_ctrlTab.js
>+ var eventConsumed = true;
>+ document.addEventListener("keypress", function (event) {
>+ eventConsumed = event.getPreventDefault();
>+ }, false);
>+ EventUtils.synthesizeKey("VK_TAB", { ctrlKey: true });
>+ ok(eventConsumed, "Ctrl+Tab consumed by the tabbed browser if one tab is open");
It would be good to also check that focus is correct (i.e. test for the symptom, not only the fix).
|
|
Assignee | |
Comment 9•16 years ago
|
||
I wasn't able to get synthesizeKey("VK_TAB", { ctrlKey: true });
change the focus even without this patch applied.
|
|
||
Comment 10•16 years ago
|
||
I suppose the focus event is dispatched asynchronously.
|
|
Assignee | |
Comment 11•16 years ago
|
||
checking focusedWindow did the trick...
http://hg.mozilla.org/mozilla-central/index.cgi/rev/315d6564407b
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite? → in-testsuite+
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
|
Reporter | |
Comment 12•16 years ago
|
||
Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080812045727 Minefield/3.1a2pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•