Closed
Bug 446647
Opened 16 years ago
Closed 16 years ago
Checkboxes and radio buttons no longer scale in HTML
Categories
(Core :: Widget: Cocoa, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b2
People
(Reporter: bzbarsky, Assigned: mstange)
References
()
Details
(Keywords: regression, verified1.9.1)
Attachments
(1 file)
(deleted),
image/png
|
Details |
Testcase is in the URL bar.
EXPECTED RESULTS: Checkbox and radio are 100px tall and wide
ACTUAL RESULTS: The styles have no effect.
The reason for this is that nsNativeThemeCocoa::GetMinimumWidgetSize sets these sizes as not overridable. This has been a problem since very early on, and it's not clear to me why it does that. Windows does NOT do this, so this leads to significant layout differences. In any case, this is clearly breaking the intended layout, so we shouldn't be doing it.
This worked fine in Firefox 2.
I suggest simply removing the PR_FALSE setting and letting the page override. I see no reason this was done as it was initially.
Flags: blocking1.9.1?
Component: Widget: Mac → Widget: Cocoa
QA Contact: mac → cocoa
Assignee | ||
Comment 1•16 years ago
|
||
While we're at it, couldn't we just remove the minimum size completely? We can just scale down smaller controls which would also make zooming out more beautiful.
And we'd have to change the default sizes for XUL checkboxes / radiobuttons in pinstripe's checkbox.css / radio.css.
Reporter | ||
Comment 2•16 years ago
|
||
The minimum size is the minimum size the OS theme engine will paint the control at. We can remove that only if we drop the native theming.
Assignee | ||
Comment 3•16 years ago
|
||
In nsNativeThemeCocoa.mm we're scaling native themed controls all over the place. I've created a patch that drops the minimum size for checkboxes and radiobuttons and still uses the native theming.
Reporter | ||
Comment 4•16 years ago
|
||
Sweet. If we can do that, so much the better!
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
This really isn't a P1 blocker -- it's at best a P3 (before final) blocker, IMO. P1 is blocking beta next week...
Assignee | ||
Comment 7•16 years ago
|
||
Fixed by bug 394892.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
Updated•16 years ago
|
Keywords: fixed1.9.1
Comment 8•16 years ago
|
||
verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090414 Minefield/3.6a1pre ID:20090414030735
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090414 Shiretoko/3.5b4pre ID:20090414035212
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•