At the time the code for bug 382267 was written the spec used different names for some attributes. This patch uses the new names for the attributes, and adds/removes other attributes that were changed in the spec. Spec is here: http://www.whatwg.org/specs/web-apps/current-work/#video This patch also fixes a bug that causes a crash when creating a video and adding it to the DOM via javascript.

+ nsresult PickMediaElement(nsAString& aChosenMediaResource); + virtual nsresult InitializeDecoder(nsAString& aChosenMediaResource); These probably should be const nsAString& It's probably worth adding an NS_IMPL_UINT_ATTR macro, but lets do that as a separate bug to make things easier to review. Do these tests need to be conditional on MOZ_MEDIA somehow? Otherwise looks good.

The string aChosenMediaResource is used as a return value. It gets assigned the url of the media resource that is picked to be displayed. The tests are conditional on MOZ_MEDIA via the Makefile for content/media. This only gets included if MOZ_MEDIA is set, and so the tests are only included if that is set.

Oops, I thought you were going to attach a new patch but you didn't need to. I'll land this when I get a chance.

Pushed 20427bfb85bc