Closed Bug 448070 Opened 16 years ago Closed 6 years ago

"Set as evaluation object" broken

Categories

(Other Applications Graveyard :: Venkman JS Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: asrail, Assigned: rginda)

References

Details

The Interactive Session fails to execute any code on the context of any object set as evaluation object. That fails with: "JavaScript strict warning: chrome://venkman/content/venkman-eval.js, line 50: eval accepts only one parameter" due to bug 442333. I know bug 446026 would make it work again, but JSD should expose this possibility to Venkman, regardless eval with the second parameter being available to content. A Sandbox wouldn't help on every use case of the interactive session, since it was possible to change the properties of any object and see its changes at live. With some hack it would be possible to make it work with a Sandbox the way it is now, but changing the attributes directly instead of having to copy from the Sandbox is faster.
This WFM now that bug 446026 is fixed. (In reply to comment #0) > JSD should expose this possibility to Venkman, regardless eval with the > second parameter being available to content. Can we close this bug or do you want to morph it?
Detailed steps: 1 - select "Open windows" tab 2 - set navigator.xul, browser.xul or any other document 3 - right click and "Set as evaluation object" 4 - run the following code: var x = 1 x Expected: 1 Issue: ReferenceError: x is not defined @ <x-jsd:interactive-session> I'm testing on 1.9.1 with the patch from bug 446025 and fails with: EvalError: function eval must be called directly, and not by way of a function of another name @ <x-jsd:interactive-session> It looks easy to fix.
(In reply to comment #2) > It looks easy to fix. Can you elaborate on that statement? :-)
I ran into this bug while attempting to go through the tutorial (http://www.svendtofte.com/code/learning_venkman/basics.php "Setting the context"). "Click on the little plus next to "Navigator Window", and it should show the file name of the file you loaded into Mozilla, venkman_example_1.html. If you're reading this page in Mozilla, it will show this page as well. Right click on the file, and select "Set as evaluation object", as in Figure 16. "Now you've set the HTML file as the current evaluation object. JavaScript you enter now, can manipulate the loaded document, and it can extract information from the same document. Try entering "document.title" into the Interactive session (which you will notice also says it's now using the document, as the evaluation context). "You'll see it answer back the title of the current document." Yeah, only not the one set as the current evaluation object. Given that it hits people within a few minutes of trying to learn how to use the tool, I'd like to see it fixed sooner rather than later. Failing that, edit the tutorial so we know what to do instead. I'm going to carry on in hopes that there are other ways to use the tool on a particular object.
This is still not working! Venkman 0.9.89 and SeaMonkey 2.16 on Mac OS X Lion 10.7.5. I was attempting to go through the same tutorial of comment 4 and I've soon faced this bug. (In reply to kajaco2 from comment #4) > Given that it hits people within a few minutes of trying to learn how to use > the tool, I'd like to see it fixed sooner rather than later. Failing that, > edit the tutorial so we know what to do instead. I couldn't agree more. Is there any workaround available?
Component is obsolete so resolving bugs as INCOMPLETE
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.