Closed
Bug 448928
Opened 16 years ago
Closed 16 years ago
remove gIsLoadingBlank and gMustLoadSidebar from browser.js
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3.1b1
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #332109 -
Flags: review?(mano)
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #332109 -
Attachment is obsolete: true
Attachment #332111 -
Flags: review?(mano)
Attachment #332109 -
Flags: review?(mano)
|
|
Assignee | |
Updated•16 years ago
|
Summary: remove gIsLoadingBlank from browser.js → remove gIsLoadingBlank and gMustLoadSidebar from browser.js
|
|
Assignee | |
Updated•16 years ago
|
Attachment #332109 -
Attachment description: patch → remove gIsLoadingBlank
|
|
Assignee | |
Updated•16 years ago
|
Attachment #332111 -
Flags: review?(mano) → review?(gavin.sharp)
|
||
Updated•16 years ago
|
Attachment #332111 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
I pushed this:
http://hg.mozilla.org/mozilla-central/rev/fe7b69d1fcdf
... and realized that my local patch was newer and more verbose than what I had attached here -- contains lots of drive-by cleanup that's rather unrelated to gIsloadingBlank and gMustLoadSidebar.
Attachment #336624 -
Flags: review?(gavin.sharp)
|
|
||
Updated•16 years ago
|
Attachment #336624 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
|
||
Comment 3•16 years ago
|
||
Some extensions like TabMixPlus expect variables like gIsLoadingBlank. Not sure if they're to be contacted.. but I can't seem to find their bugmail addresses.
|
|
Assignee | |
Comment 4•16 years ago
|
||
TMP should be able to use isLoadingBlank instead of gIsLoadingBlank, since it "rewrites" part of BrowserStartup (toString + replace).
Btw, TMP gets broken regularly :)
You need to log in
before you can comment on or make changes to this bug.
Description
•