Closed
Bug 448939
Opened 16 years ago
Closed 16 years ago
XULBrowserWindow cleanup
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3.1b1
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
- remove nsBrowserStatusHandler
- use smart getters
- stop setting the level attribute on the urlbar (made obsolete in Fx3)
- show / hide the security button in app code rather than in the themes
Attachment #332113 -
Flags: review?(mano)
Assignee | ||
Comment 1•16 years ago
|
||
(In reply to comment #0)
> - use smart getters
except for elements that can be added / removed by customizing the toolbars
(i.e.: except for the throbber)
Updated•16 years ago
|
Attachment #332113 -
Flags: review?(mano) → review+
Comment 2•16 years ago
|
||
Comment on attachment 332113 [details] [diff] [review]
patch
r=mano
Assignee | ||
Comment 3•16 years ago
|
||
pushed as changeset 18939:e6b88d928273
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
Comment 4•16 years ago
|
||
This caused a bug in browser.js:
let location = aRequest.URI;
This was previously declared with the "var" keyword and is used outside the block. Now |if (!msg && (!location || location.spec != "about:blank"))| doesn't have this variable in scope any more and gets window.location instead. Hence the warning "reference to undefined property location.spec".
Comment 5•16 years ago
|
||
Note that the patch that was checked in was quite a bit more extensive than the one attached (and reviewed) here...
Assignee | ||
Comment 6•16 years ago
|
||
Yeah, that one didn't apply anymore -- my local up-to-date patch contained more drive-by cleanup.
Comment 7•16 years ago
|
||
Dao,
We need the urlbar level attribute back. At a time with Google Chrome breathing down our necks, we need to be giving users more choice, not less. Many users want a yellow urlbar for the https state.
Assignee | ||
Comment 8•16 years ago
|
||
(In reply to comment #7)
> Many users want a yellow urlbar for the https state.
Something like this should work:
#identity-box.verifiedDomain + .textbox-input-box ,
#identity-box.verifiedDomain ~ #urlbar-icons {
background: ...;
}
You need to log in
before you can comment on or make changes to this bug.
Description
•