Closed Bug 449154 Opened 16 years ago Closed 16 years ago

nsHTMLMediaElement::play() doesn't reset properly

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jcranmer, Assigned: cajbir)

References

()

Details

Attachments

(1 file, 2 obsolete files)

If the playback has ended, then the user agent must set currentLoop to zero and seek to the effective start.

If this involved a seek, the user agent will fire a simple event called timeupdate at the media element.

(quotation from URI listed in the URL field).
Attached patch Refactoring of playback to fix this bug (obsolete) (deleted) — Splinter Review
First cut at a patch to fix this. Requires patch from bug 449159 to be applied first.
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
Depends on: 449159
Attached patch Second cut at patch (obsolete) (deleted) — Splinter Review
Change patch to work with bug 449159 changes.
Attachment #333658 - Attachment is obsolete: true
Attached patch Fix playback after end issues (deleted) — Splinter Review
When playback ends it currently immediately seeks back to the beginning of the file. This patch fixes it so it does this when playback is next requested instead.

The included tests have a time check commented out. These will be uncommented when bug 460871 is done. It relies on a fix in that bug. That bug also relies on the fix in this bug so I had to pick one to have the test commented out.
Attachment #340053 - Attachment is obsolete: true
Attachment #344016 - Flags: superreview?(roc)
Attachment #344016 - Flags: review?(roc)
Blocks: 460871
Attachment #344016 - Flags: superreview?(roc)
Attachment #344016 - Flags: superreview+
Attachment #344016 - Flags: review?(roc)
Attachment #344016 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/b44fe4f84e1d
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: