Closed
Bug 449171
Opened 16 years ago
Closed 15 years ago
[FIX]"ASSERTION: media list must be nonempty"
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: bzbarsky)
References
()
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: media list must be nonempty: 'media->Count() != 0', file /Users/jruderman/central/layout/style/nsCSSParser.cpp, line 1838
|
Assignee | |
Comment 1•16 years ago
|
||
This assertion should just be removed (and maybe also for @import). In the new media query world, |@media {}| is equivalent to |@media all {}|.
|
|
Assignee | |
Comment 2•16 years ago
|
||
Is the change in behavior for @media correct here, though? Neither Opera nor Safari seem to allow @media with no media, but they might not implement this part of media queries yet, I guess.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #335581 -
Flags: superreview?(dbaron)
Attachment #335581 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•16 years ago
|
Summary: "ASSERTION: media list must be nonempty" → [FIX]"ASSERTION: media list must be nonempty"
|
||
Comment 3•16 years ago
|
||
Comment on attachment 335581 [details] [diff] [review]
Like so
r+sr=dbaron
Attachment #335581 -
Flags: superreview?(dbaron)
Attachment #335581 -
Flags: superreview+
Attachment #335581 -
Flags: review?(dbaron)
Attachment #335581 -
Flags: review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed changeset 47e1265cbf69.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Comment 5•15 years ago
|
||
This reftest is failing for Fedora unit tests (see bug 560882).
I have machines available to help fixing it.
Let me know if it should make sense to file another bug instead of reopening this one.
|
|
Assignee | |
Comment 6•15 years ago
|
||
Please file new bugs on new issues. This bug is fixed.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•