Closed Bug 449360 Opened 16 years ago Closed 16 years ago

No controls after enabling it thru JavaScript

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: BijuMailList, Unassigned)

References

Details

(Keywords: testcase)

Attachments

(2 files)

Attached file modified 008.htm (deleted) —
NB: this not same as Bug #449358 Steps: 1. ensure Javascript is enabled 2. Goto URL http://simon.html5.org/test/html/semantics/video/008.htm (or the attached modified testcase) Result:- User dont see controls Expected:- There should be controls on video element.
Blocks: 449522
This worksforme now, anybody else have this problem still?
works for me too, whereas it didn't used to work for me before.
may be fixed after patch related to bug 448909 or bug 449522 We need to put this in test suite
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite?
Resolution: --- → WORKSFORME
Bug 448909 fixed this, is seemed to be a problem caused by having the XBL binding removed when disabling controls (now the binding is just always active).
Attached patch simple mochitest (deleted) — Splinter Review
simple test
Attachment #381008 - Flags: review?
Attachment #381008 - Flags: review? → review?(roc)
I don't think this test actually tests what you want. hasAttribute('controls') returning true doesn't mean controls are actually visible. Maybe we could have a reftest that compares two video elements which should both be showing controls, where one of the tests adds the 'controls' attribute dynamically.
Component: Video/Audio → Video/Audio Controls
Product: Core → Toolkit
QA Contact: video.audio → video.audio
Version: Trunk → unspecified
Comment on attachment 381008 [details] [diff] [review] simple mochitest needs to be updated per comment #6
Attachment #381008 - Flags: review?(roc) → review-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: