Closed
Bug 449375
Opened 16 years ago
Closed 16 years ago
Use the new search textbox binding in the Places organizer
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3.1a2
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #332514 -
Flags: review?(mano)
Assignee | ||
Updated•16 years ago
|
Attachment #332514 -
Flags: review?(mano) → review?(dietrich)
Comment 1•16 years ago
|
||
Comment on attachment 332514 [details] [diff] [review]
patch
>diff --git a/browser/components/places/content/places.xul b/browser/components/places/content/places.xul
>--- a/browser/components/places/content/places.xul
>+++ b/browser/components/places/content/places.xul
>@@ -381,19 +381,20 @@
> </toolbarbutton>
> #else
> </menu>
> </menubar>
> #endif
>
> <spacer flex="1"/>
>
>- <textbox id="searchFilter" style="width: 23em;" timeout="500" clickSelectsAll="true"
>+ <textbox id="searchFilter"
>+ clickSelectsAll="true"
>+ type="search"
> oncommand="PlacesSearchBox.search(this.value);"
>- onreset="PlacesOrganizer.onPlaceSelected(false);"
> collection="bookmarks">
> </textbox>
does the reset get hooked up another way w/ the new binding? i didn't see it elsewhere in the patch.
Attachment #332514 -
Flags: review?(dietrich)
Assignee | ||
Comment 2•16 years ago
|
||
Comment on attachment 332514 [details] [diff] [review]
patch
A reset is nothing but a search with an empty string, which is handled by the oncommand attribute.
Attachment #332514 -
Flags: review?(dietrich)
Comment 3•16 years ago
|
||
Comment on attachment 332514 [details] [diff] [review]
patch
r=me, thanks!
Attachment #332514 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 4•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
Comment 5•16 years ago
|
||
Verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080817033619 Minefield/3.1a2pre ID:20080817033619
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080817040141 Minefield/3.1a2pre ID:20080817040141
Status: RESOLVED → VERIFIED
Comment 6•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•