Closed
Bug 449422
Opened 16 years ago
Closed 16 years ago
[FIX]Assert early on bogus display types for table rows
Categories
(Core :: Layout: Tables, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bernd_mozilla
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
We currently assert about bogus display on table rows, but we do it during layout. Better to do it as the frame tree is being constructed, so we can debug why it's happening.
Patch attached.
Attachment #332549 -
Flags: superreview?(roc)
Attachment #332549 -
Flags: review?(bernd_mozilla)
Comment on attachment 332549 [details] [diff] [review]
Fix
yep that is what I want
Attachment #332549 -
Flags: review?(bernd_mozilla) → review+
Comment on attachment 332549 [details] [diff] [review]
Fix
Shouldn't we take the assertions out of layout, as well?
Attachment #332549 -
Flags: superreview?(roc) → superreview+
|
Assignee | |
Comment 3•16 years ago
|
||
I'd like to keep those for now. They've also caught issues with style data becoming bogus in the past.
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed changeset e7c43898c379.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 5•16 years ago
|
||
Backed out, tracking down Tp regression in bug 450401. (Yeah, no idea how this could be it.)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 6•16 years ago
|
||
Relanded.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•