Closed Bug 449687 Opened 16 years ago Closed 13 years ago

Altering a valid saved search to include a folder containing a pipe character crashes Thunderbird on startup

Categories

(MailNews Core :: Database, defect)

x86
Linux
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: bugzilla, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en; rv:1.8.1.16) Gecko/20080805 Epiphany/2.22 Firefox/2.0.0.16
Build Identifier: version 2.0.0.16 (20080805)

If you take a valid saved search and alter the list of searched-folders to include one with a pipe-character in its name, Thunderbird behaves strangely by not showing any results in the folder, and not showing any messages in the first subsequent folder to be selected.

Furthermore and more importantly, Thunderbird will crash upon subsequent startups immediately after (briefly) showing the main window.

Reproducible: Always

Steps to Reproduce:
1. Have an IMAP account.
2. Create a folder within that account with a pipe-character in the name e.g.
"pipe|folder".
3. Create a new saved search, name it "test", leave the default
search-criteria.
4. Select the 'Choose' button to pop-up the 'Select Folder(s)' window, select "Inbox", click 'OK' twice to save the search.
5. Observe that the saved-search works correctly.
6. Right-click on the saved-search, select 'Properties'.
7. Select the 'Choose' button to pop-up the 'Select Folder(s)' window, select "pipe|folder", click 'OK' twice to save the search.
(7b. [optional] select the saved search folder, then select any other folder; observe strange behaviour rendering message list)
8. Close Thunderbird, and restart it.
Actual Results:  
Thunderbird crashes on startup, immediately after showing the main window.

Expected Results:  
Thunderbird starts normally. Saved search functions as expected by searching in "pipe|folder" using relevant criteria.

I tried this with a folder under the "Local Folders" account and was unable to reproduce it.

The problem seems to stem from the fact that the file virtualFolders.dat in my profile directory (which records the saved searches) stores the list of folders to search in a pipe-separated format without correctly escaping any folders that contain the pipe-character in their name.

Manually-editing the virtualFolders.dat file to replace the offending pipe-character with %7c allows Thunderbird to start, but the saved-search still does not function as expected.
The error is almost certainly caused by the final pipe-character in the line beginning "scope".
This bug is very-probably related to bug 449683.
Bug 383423 is base problem. (See dependency tree for meta bug 124287)
But "rename case" sometimes involves different/additional issue from "creation case". Setting dependency to Bug 383423, in order to avoid loss of "rename case".  
no sense keepgin this UNCO. just test it once Bug 383423 is fixed.
Status: UNCONFIRMED → NEW
Component: General → Database
Ever confirmed: true
Product: Thunderbird → MailNews Core
QA Contact: general → database
Keywords: crash
Nick, can you reproduce this with a recent build/version?

I can't reproduce With current trunk on vista, in local or imap account
With the version of 3.1.9 I've got installed here ("Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110326 Lightning/1.0b3pre Thunderbird/3.1.9") I can't reproduce the crash when trying various combinations of selecting the-folder-with-the-pipe-in and other-folders.

Having said that, the search still doesn't work correctly for me, and my virtualFolders.dat still contains an incorrectly-escaped line:

$ grep scope= virtualFolders.dat | tail -1
scope=imap://nick@nick.grimshaw.name/Republic|imap://nick@nick.grimshaw.name/pipe|folder

Is here the correct place for steps-to-reproduce, or should I open another bug?
(In reply to comment #6)
 
> $ grep scope= virtualFolders.dat | tail -1
> scope=imap://nick@nick.grimshaw.name/Republic|imap://nick@nick.grimshaw.name/pipe|folder
> 
> Is here the correct place for steps-to-reproduce, or should I open another bug?

File a new bug please.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: