Closed
Bug 449780
Opened 16 years ago
Closed 16 years ago
[FIX]Frameloader swap doesn't play nice with bfcache
Categories
(Core :: DOM: Navigation, defect, P1)
Core
DOM: Navigation
Tracking
()
VERIFIED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: addon-compat, verified1.9.1)
Attachments
(1 file)
|
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Swapping frameloaders blows away layout on the two current pages, but the bfcache layouts remain, with stale parent viewmanager/widget/etc pointers. We should be blowing those away too.
This we certainly need for 1.9.1 if we're going to do the drag/drop thing...
Flags: blocking1.9.1?
|
||
Updated•16 years ago
|
Flags: blocking1.9.1? → blocking1.9.1+
|
|
||
Updated•16 years ago
|
Priority: -- → P1
|
||
Comment 1•16 years ago
|
||
This is one of the known late-compat exceptions we're taking in Beta 3. Blizz, Sheppy, Fligtar: FYI. The compatibility hit here is near-negligible, according to bz, but full disclosure! :)
Keywords: late-compat
|
||
Comment 2•16 years ago
|
||
Rey + Paul - can you make sure this ends up on the 3.1 page for add-ons developers?
|
Assignee | |
Comment 3•16 years ago
|
||
It sucks that we have to walk the whole session history, but oh, well.
Attachment #356083 -
Flags: superreview?(jst)
Attachment #356083 -
Flags: review?(jst)
|
|
Assignee | |
Updated•16 years ago
|
No longer depends on: 396519
Summary: Frameloader swap doesn't play nice with bfcache → [FIX]Frameloader swap doesn't play nice with bfcache
|
||
Updated•16 years ago
|
Attachment #356083 -
Flags: superreview?(jst)
Attachment #356083 -
Flags: superreview+
Attachment #356083 -
Flags: review?(jst)
Attachment #356083 -
Flags: review+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 356083 [details] [diff] [review]
Fix
Looks good!
|
|
Assignee | |
Comment 5•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•16 years ago
|
||
Er, ignore comment 5. What I really pushed here is http://hg.mozilla.org/mozilla-central/rev/f0a8064d5a8e
|
|
Assignee | |
Comment 7•16 years ago
|
||
Keywords: fixed1.9.1
|
||
Comment 8•16 years ago
|
||
Seeing as there hasn't been any discussions about this bug for 3 months and it's been in mochitest, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•