Closed Bug 450502 Opened 16 years ago Closed 16 years ago

nsNavHistoryExpire::ClearHistory has a defective query

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: sdwilsh, Assigned: mak)

References

(
URL
)

Details

The first query in nsNavHistoryExpire::ClearHistory is missing a closing paren.  It'll always not work.  Consequentially, it means we don't have a unit test for this code path!
Flags: in-testsuite?
Assignee: nobody → mak77
Flags: blocking1.9.1?
This probably has never been caught because we just issue an NS_WARNING if the query fails.  There's really no reason to issue a warning like that though, and we should probably use NS_ENSURE_SUCCESS
note: also add a test for reset frecency query in EraseVisits
the query has been fixed by fsync stuff, this needs only a test
bug 463471 contains also a test for this
Depends on: 463471
no more blocking since bug is fixed, missing only tests
Flags: blocking1.9.1?
Whiteboard: [needs test]
test pushed with bug 463471
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1a2 → mozilla1.9.1b2
Flags: in-testsuite? → in-testsuite+
Whiteboard: [needs test]
You need to log in before you can comment on or make changes to this bug.