Closed
Bug 450675
Opened 16 years ago
Closed 16 years ago
Fix test_expiration.js
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a2
People
(Reporter: sdwilsh, Assigned: dietrich)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #333859 -
Flags: review?(sdwilsh)
|
Reporter | |
Comment 2•16 years ago
|
||
Comment on attachment 333859 [details] [diff] [review]
fix
>+ histsvc.addVisit(testURI, (Date.now() - (86400 * 4 * 1000)) * 1000, null, histsvc.TRANSITION_TYPED, false, 0);
So, the 4 is days, and the 1000 is the Date.now() to PR_Time conversion, but I don't really know what the 86400 is for without much thinking. Could you make that a constant please?
r=sdwilsh
I can't believe I'm actually understanding this code now. *sigh*
Attachment #333859 -
Flags: review?(sdwilsh) → review+
|
|
Reporter | |
Updated•16 years ago
|
Whiteboard: [has patch][has review][can land]
|
|
Reporter | |
Comment 3•16 years ago
|
||
Pushed to mozilla-central (although I managed to use the wrong bug number...):
http://hg.mozilla.org/mozilla-central/index.cgi/rev/1997aa804c6c
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
You need to log in
before you can comment on or make changes to this bug.
Description
•