Closed
Bug 450772
Opened 16 years ago
Closed 16 years ago
[th] Adding longdo search suggestion.
Categories
(Mozilla Localizations :: th / Thai, defect)
Mozilla Localizations
th / Thai
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kengggg, Unassigned)
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
image/png
|
Details |
screenshot of longdo search suggestion. testing locally from thailand.
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Build Identifier:
Regarding to Bug 443375, Longdo team just finish implementing search suggestion, therefore this patch is about adding search suggestion to longdo.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
|
Reporter | |
Comment 1•16 years ago
|
||
Attachment #333964 -
Flags: review?
|
|
Reporter | |
Updated•16 years ago
|
Attachment #333964 -
Flags: review? → review?(l10n)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 333964 [details] [diff] [review]
Patch for longdo search suggestion.
I'd prefer the URL to be with <Param>, too, that's easier to digest.
Did you test this locally? I'm asking because there's a timeout of 500ms for suggestions, which it's not hitting here from Germany, I guess. It could be totally fine from Thailand, though.
Attachment #333964 -
Flags: review?(l10n) → review-
|
|
Reporter | |
Comment 3•16 years ago
|
||
New patch, use <Param> as Axel's suggestion.
Attachment #333969 -
Flags: review?(l10n)
|
|
Reporter | |
Comment 4•16 years ago
|
||
from the latest patch. it works fine from my machine in thailand.
|
|
Reporter | |
Updated•16 years ago
|
Attachment #333964 -
Attachment is obsolete: true
|
|
||
Comment 5•16 years ago
|
||
Comment on attachment 333969 [details] [diff] [review]
Patch for longdo search suggestion.
r=me, please land this with a check-in comment referencing this bug and my review, something like "bug 450772, add suggestion support to londo search, r=l10n@mozilla.com" would do.
Attachment #333969 -
Flags: review?(l10n) → review+
|
|
Reporter | |
Comment 6•16 years ago
|
||
landed.
marked as FIXED.
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•