Closed
Bug 450871
Opened 16 years ago
Closed 16 years ago
Crash [@ str_lastIndexOf] with proto and lastIndexOf
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: gkw, Assigned: mrbkap)
References
Details
(Keywords: crash, testcase)
Crash Data
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
__proto__ = <x/>; <x/>.lastIndexOf(this, false)
I found and reduced to the testcase above, it crashes latest trunk js shell, both opt and debug at null.
1.9.0.x js shell works as expected, which shows the message "typein:1: TypeError: XML.prototype.toString called on incompatible global".
Assignee | ||
Comment 1•16 years ago
|
||
Assignee | ||
Comment 2•16 years ago
|
||
The typos were introduced by the patch for bug 412296.
Blocks: 412296
Comment 3•16 years ago
|
||
Comment on attachment 334108 [details] [diff] [review]
Fix
Sorry about the typos.
Attachment #334108 -
Flags: review?(igor) → review+
Reporter | ||
Updated•16 years ago
|
Keywords: regression
Reporter | ||
Updated•16 years ago
|
Keywords: regression
Reporter | ||
Comment 4•16 years ago
|
||
For the purpose of automated testing, here is another crash testcase involving IndexOf instead of lastIndexOf:
__proto__ = <x/>; <x/>.indexOf(this)
A similar crash that crashes at null and at str_indexOf.
Assignee | ||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•16 years ago
|
||
Verifying in both opt and debug js shells. They now work as expected.
Console output:
$ ./js-trunk-intelmac
js> __proto__ = <x/>; <x/>.lastIndexOf(this, false)
typein:1: TypeError: XML.prototype.toString called on incompatible global
js> __proto__ = <x/>; <x/>.indexOf(this)
typein:2: TypeError: XML.prototype.toString called on incompatible global
js>
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•16 years ago
|
Flags: in-testsuite?
Comment 7•16 years ago
|
||
/cvsroot/mozilla/js/tests/e4x/extensions/regress-450871-01.js,v <-- regress-450871-01.js
initial revision: 1.1
/cvsroot/mozilla/js/tests/e4x/extensions/regress-450871-02.js,v <-- regress-450871-02.js
initial revision: 1.1
http://hg.mozilla.org/mozilla-central/rev/a4ac2862212d
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus-
Updated•13 years ago
|
Crash Signature: [@ str_lastIndexOf]
You need to log in
before you can comment on or make changes to this bug.
Description
•