Closed Bug 450957 Opened 16 years ago Closed 16 years ago

Make Qt port compile with comm-central

Categories

(MailNews Core :: Build Config, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(1 file)

Bug 448989 landed the new Qt port on mozilla-central, we need a few changes for the comm-central build system to be able to build SeaMonkey and Thunderbird with that port. I guess we might need the toolkit definitions in our own code in some places, so we probably want all those ported.
I haven't tested this yet but will still do so today. This ports all buildsystem fixes that have been merged from the qt branch to mozilla-central over to comm-central - with the exception of cairo qpainter support (I think that we can probably remove most of this cairo configuration stuff from comm-central).
Attachment #334175 - Flags: review?(bugzilla)
Comment on attachment 334175 [details] [diff] [review] port all qt branch buildsystem fixes over to comm-central So the only thing I can see missing with this patch is that our Makefile.in with $(MOZ_WIDGET_TOOLKIT) lines need to have qt added where appropriate. Not sure if you're wanting to cover that here, but this patch definitely looks ok.
Attachment #334175 - Flags: review?(bugzilla) → review+
(In reply to comment #2) > (From update of attachment 334175 [details] [diff] [review]) > So the only thing I can see missing with this patch is that our Makefile.in > with $(MOZ_WIDGET_TOOLKIT) lines need to have qt added where appropriate. Not > sure if you're wanting to cover that here, but this patch definitely looks ok. You're right in that I'd prefer to make that an additional patch, I only wanted to port the changes in the base build system in the patch here.
pushed as http://hg.mozilla.org/comm-central/rev/5e422392425a - please file additional bugs on further problems with building the Qt port
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: SeaMonkey → MailNews Core
QA Contact: build-config → build-config
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: