Closed
Bug 451185
Opened 16 years ago
Closed 16 years ago
add a build target to compare bin/ and the package list
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
To be able to check if our package lists are OK, it would be nice to have a build target that outputs a diff of the dist/bin directory and the files in the package list. This gives us a fast check what we aren't packaging and what we have in the package list that isn't built any more. Our builder boxes could even execute that so we can look into their logs and see that package diff easily.
Assignee | ||
Comment 1•16 years ago
|
||
This adds a "package-compare" target callable from the objdir toplevel. I tested this on Linux, I hope it works on Windows (testing wanted!) - Mac should not produce any output as we have no package manifest there currently.
Attachment #334470 -
Flags: review?(bugzilla)
Assignee | ||
Comment 2•16 years ago
|
||
Comment on attachment 334470 [details] [diff] [review]
add package-compare target
>diff --git a/suite/installer/Makefile.in b/suite/installer/Makefile.in
>+ cd $(DIST); find -L bin -type f | sort > bin-list.txt
Note to self: We need a var for the find options that varies per-platform, as -L (dereference symlinks) doesn't work on Windows.
Assignee | ||
Comment 3•16 years ago
|
||
Here's a new version, updated for what testing on Windows revealed (thanks mcsmurf!).
Attachment #334470 -
Attachment is obsolete: true
Attachment #334554 -
Flags: review?(bugzilla)
Attachment #334470 -
Flags: review?(bugzilla)
Updated•16 years ago
|
Attachment #334554 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 4•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Flags: in-testsuite?
Hardware: PC → All
Target Milestone: --- → seamonkey2.0alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•