Closed
Bug 451522
Opened 16 years ago
Closed 16 years ago
1px border with radius and outset are not right
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
DUPLICATE
of bug 448193
People
(Reporter: alfredkayser, Unassigned)
References
Details
(Keywords: regression, testcase)
Attachments
(1 file)
(deleted),
text/html
|
Details |
This is a regression caused by bug 368247.
Boxes with a 1px outset color border and border-radius are not drawn as 'outset'. It seems that the whole border is drawn with the darker tint.
See attached image, which is a enlarge capture of the attached testcase.
This problem doesn't occur in FF2.
Reporter | ||
Comment 1•16 years ago
|
||
The problem seems to be around here:
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsCSSRendering.cpp#2641:
2641 case NS_STYLE_BORDER_STYLE_RIDGE:
2642 if ((horizontal && (twipsPerPixel >= aBorder.height)) ||
2643 (!horizontal && (twipsPerPixel >= aBorder.width))) {
2644 // a one pixel border
2645 DrawSolidBorderSegment(aContext, aBorder, twipsPerPixel, aStartBevelSide, aStartBevelOffset,
2646 aEndBevelSide, aEndBevelOffset);
2647 }
2648 else {
2649 nscoord startBevel = (aStartBevelOffset > 0)
2650 ? RoundFloatToPixel(0.5f * (float)aStartBevelOffset, twipsPerPixel, PR_TRUE) : 0;
2651 nscoord endBevel = (aEndBevelOffset > 0)
2652 ? RoundFloatToPixel(0.5f * (float)aEndBevelOffset, twipsPerPixel, PR_TRUE) : 0;
2653 PRUint8 ridgeGrooveSide = (horizontal) ? NS_SIDE_TOP : NS_SIDE_LEFT;
2654 aContext.SetColor (
2655 MakeBevelColor(ridgeGrooveSide, ridgeGroove, aBGColor->mBackgroundColor, aBorderColor));
2656 nsRect rect(aBorder);
2657 nscoord half;
2658 if (horizontal) { // top, bottom
When the border is 1px, the code doesn't seem to call MakeBevelColor...
(In reply to comment #1)
> The problem seems to be around here:
> http://mxr.mozilla.org/mozilla-central/source/layout/base/nsCSSRendering.cpp#2641:
You're looking at DrawTableBorderSegment, and these aren't tables...
Comment 3•16 years ago
|
||
I can confirm this Bug. Should my Bug 448193 be marked as duplicate?
You need to log in
before you can comment on or make changes to this bug.
Description
•