Closed
Bug 451533
Opened 16 years ago
Closed 16 years ago
Make sure all names are truncated throughout platform-independent module
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
Adding missing aName.Truncate() calls to various ::getName methods in a11y platform independent code. Patch coming up.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: nobody → marco.zehe
Attachment #334859 -
Flags: review?(surkov.alexander)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 334859 [details] [diff] [review]
Patch
> NS_IMETHODIMP
> nsApplicationAccessible::GetName(nsAString& aName)
> {
>+ aName.Truncate();
nit: new line here please and below if applicable
>@@ -125,16 +125,18 @@ NS_IMETHODIMP nsRootAccessible::GetName(
> }
>
> if (mRoleMapEntry) {
> nsAccessible::GetName(aName);
> if (!aName.IsEmpty()) {
> return NS_OK;
> }
> }
>+
>+ aName.Truncate();
I would prefer to truncate the name in the begin of method if it's applicable here, fix the same below
>
>-NS_IMETHODIMP nsXULColorPickerTileAccessible::GetName(nsAString& _retval)
>+NS_IMETHODIMP nsXULColorPickerTileAccessible::GetName(nsAString& aName)
use
NS_IMETHODIMP
nsXULColorPickerTileAccessible::GetName(nsAString& aName)
fix the same below
>
>-NS_IMETHODIMP nsXULMenubarAccessible::GetName(nsAString& _retval)
>+NS_IMETHODIMP nsXULMenubarAccessible::GetName(nsAString& aName)
> {
>- _retval.AssignLiteral("Application");
>+ aName.Truncate();
>+ aName.AssignLiteral("Application");
no need to truncate it here.
let me loot at the next patch
Attachment #334859 -
Flags: review?(surkov.alexander)
|
|
Assignee | |
Comment 3•16 years ago
|
||
I now also wrapped those function headers that didn't get a parameter change, to make them all consistent.
Attachment #334859 -
Attachment is obsolete: true
Attachment #334863 -
Flags: review?(surkov.alexander)
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 334863 [details] [diff] [review]
Patch2, addressing Surkov's comments
nice, r=me
Attachment #334863 -
Flags: review?(surkov.alexander) → review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Pushed in changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/e42742425925
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•