Closed
Bug 451731
Opened 16 years ago
Closed 16 years ago
Update caps, dom, xpconnect for Bug 451729 (checkObjectAccess moving to the JSContext)
Categories
(Core :: Security: CAPS, defect)
Core
Security: CAPS
Tracking
()
RESOLVED
FIXED
mozilla1.9.1
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
See bug 451729, the checkObjectAccess member is moving from the runtime to the context. Attached patch gets everyone in line.
Attachment #335069 -
Flags: superreview?(jst)
Attachment #335069 -
Flags: review?(jst)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 335069 [details] [diff] [review]
Patch, v1
- In nsJSContext::CheckObjectAccess():
+ PRBool ssmOwned = PR_FALSE;
+ nsIScriptSecurityManager *ssm = sSecurityManager;
+
+ if (NS_UNLIKELY(!ssm)) {
+ rv = CallGetService(NS_SCRIPTSECURITYMANAGER_CONTRACTID, &ssm);
+ NS_ASSERTION(NS_SUCCEEDED(rv), "Failed to get security manager service");
Use nsContentUtils::GetSecurityManager() here?
r+sr=jst
Attachment #335069 -
Flags: superreview?(jst)
Attachment #335069 -
Flags: superreview+
Attachment #335069 -
Flags: review?(jst)
Attachment #335069 -
Flags: review+
|
Assignee | |
Comment 3•16 years ago
|
||
Updated patch to reflect changes in JSAPI.
Attachment #335069 -
Attachment is obsolete: true
Attachment #336756 -
Flags: superreview?(jst)
Attachment #336756 -
Flags: review?(jst)
|
|
||
Updated•16 years ago
|
Attachment #336756 -
Flags: superreview?(jst)
Attachment #336756 -
Flags: superreview+
Attachment #336756 -
Flags: review?(jst)
Attachment #336756 -
Flags: review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed changeset 825b04991820 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•