Closed
Bug 451732
Opened 16 years ago
Closed 16 years ago
JS_EvaluateUCScriptForPrincipals doesn't report pending exceptions if compile fails
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla1.9.1
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
JS_EvaluateUCScriptForPrincipals doesn't report pending exceptions if compile fails, it's missing a LAST_FRAME_CHECKS. Patch attached, thanks mrbkap for helping me find this!
Attachment #335071 -
Flags: review?(mrbkap)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 335071 [details] [diff] [review]
Patch, v1
Thanks!
Attachment #335071 -
Flags: review?(mrbkap) → review+
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 2•16 years ago
|
||
Pushed for ben as http://hg.mozilla.org/mozilla-central/index.cgi/rev/128fdb14ae8c
|
||
Updated•16 years ago
|
Flags: in-testsuite?
Flags: in-litmus-
|
|
||
Comment 3•16 years ago
|
||
bent: help with a test?
|
|
Assignee | |
Comment 4•16 years ago
|
||
So I think you just need to verify that calling JS_EvaluateUCScriptForPrincipals on a script with a compile error, not an execution error, throws properly... Something like a syntax error in a for expression or something.
FWIW I have tests for this in worker thread mochitests.
|
|
||
Updated•16 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•