Closed
Bug 45187
Opened 24 years ago
Closed 23 years ago
Inherit character coding does not work in <a href= xxxx target="new">
Categories
(Core :: Internationalization, defect, P4)
Core
Internationalization
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: teruko, Assigned: shanjian)
References
()
Details
(Keywords: helpwanted, intl)
Attachments
(3 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
This bug is separated from the bug 27646.
Inherit character coding does not work in <a href= xxxx target="new">
1. go to http://news.yahoo.co.jp/Full_Coverage/Aum/
2. select menu View|Character coding->Multibyte->Japanese (EUC-JP)
3. click on the link under "関連ニュース"
The Japanese characters in the new page are not displayed correctly.
Tested 2000-07-11-08 build.
Updated•24 years ago
|
Status: NEW → ASSIGNED
Updated•24 years ago
|
Keywords: helpwanted
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Comment 4•24 years ago
|
||
shanjian, are you working on this bug ? I think this one is more important than
the remaining IME bug.
Priority: P3 → P2
Comment 6•24 years ago
|
||
what is the progress? can you put the comment here?
Comment 7•24 years ago
|
||
shanjian said he have no good progress on this. We should consider drop this.
Whiteboard: [nsbeta3+] → [nsbeta3+](ftang:consider to cut)
Comment 8•24 years ago
|
||
cut this out from nsbeta3 list since
1. auto-detect reduce the chance that we hit this.
2. user coudl still select the character coding menu to select the right one.
Whiteboard: [nsbeta3+](ftang:consider to cut) → [nsbeta3-]
Reporter | ||
Comment 9•24 years ago
|
||
Added nsbeta1 and intl keywords.
Reporter | ||
Comment 10•24 years ago
|
||
Changed QA contact to ylong@netscape.com.
QA Contact: teruko → ylong
Comment 11•24 years ago
|
||
The url http://news.yahoo.co.jp/Full_Coverage/Aum/ has been
redirected to another one: http://dailynews.yahoo.co.jp/fc/ which
doesn't has the "関連ニュース" there.
Reporter | ||
Comment 12•24 years ago
|
||
I created test case in http://babel/tests/browser/html/euc-jp/new-target.html.
When you click "クリック", the Japanese characters in new page are not displayed correctly.
Comment 13•23 years ago
|
||
move to moz0.9.3
Whiteboard: [nsbeta3-]
Target Milestone: --- → mozilla0.9.3
Assignee | ||
Comment 14•23 years ago
|
||
This is not a easy bug. Mark it 1.0, but hope I can fix it sooner.
Target Milestone: mozilla0.9.3 → mozilla1.0
Assignee | ||
Comment 15•23 years ago
|
||
Assignee | ||
Comment 16•23 years ago
|
||
explaination to the patch:
In navigator.js, function Startup() AND
OpenBrowserWindow() in taskOverlay.js, the same thing is done through js. So we
want to do the same thing to open link in new target through link click.
Assignee | ||
Comment 17•23 years ago
|
||
rick, could you review my fix? thanks.
Comment 18•23 years ago
|
||
hi shanjian,
the patch looks good. however, i'd put the code in nsDocShell::FindTarget(...)
rather than nsDocShell::InternalLoad(...). FindTarget(...) actually creates the
new window, so i think it would be cleaner to inherit the character coding there...
r=rpotts
-- rick
Assignee | ||
Comment 19•23 years ago
|
||
Assignee | ||
Comment 20•23 years ago
|
||
add waterson to cc list. Chris, can you sr this one? thanks!
Comment 21•23 years ago
|
||
Couple nits:
1. use nsXPIDLString for |defaultCharset| instead of raw PRUnichar
pointer and |Recycle()|.
2. fix goofy tabs
3. Declaration of |defaultCharset| ought to be _inside_ the
|if (muCV && target_muCV) {|, right?
Fix those, and sr=waterson
Assignee | ||
Comment 22•23 years ago
|
||
Assignee | ||
Comment 23•23 years ago
|
||
chris, I update my patch as you suggested. By the way, is there any
documentation about those string class we are using in mozilla? It is constantly
changing and there are multiple practice in the code base, it confused me a lot
when dealing with string in mozilla.
Comment 24•23 years ago
|
||
looks good to me... r=rpotts
Comment 25•23 years ago
|
||
a=tor on behalf of drivers
Assignee | ||
Comment 26•23 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 27•23 years ago
|
||
Fixed verified on 09-04 trunk build on Win2k-CN and Linux RH6.2-Ja.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•