Bug 446281 comment 11: [ Philip Chee 2008-08-13 18:43:42 PDT while grepping through comm-central I noticed that debugQATextEditorShell.xul pulls in contentAreaContextOverlay.xul for no apparent reason, but that's grist for another bug. ]

While working on bug 520447, I noticed this cleanup: this (commented out) include was added by bug 71702: http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/suite/debugQA/content/debugQATextEditorShell.xul&rev=HEAD&mark=1.61#1.62 Bug 118594 comment 3 reports: { From Ben Goodger (use ben at mozilla dot org for email) 2002-01-13 12:27:03 PDT I suspect removing the include of contentAreaUtils.js from editor.xul will fix the problem (sidebarOverlay.xul pulls in contentAreaContextOverlay.xul which pulls in contentAreaUtils.js) } debugQATextEditorShell.xul already includes contentAreaContextOverlay.xul which includes contentAreaUtils.js.

Ftr, 1) evaluating window.openDialog("chrome://debugqa/content/debugQATextEditorShell.xul","_blank","chrome,dialog=no,all","about:blank"); in the Error Console reports { Error: redeclaration of const webPersist Source File: chrome://editor/content/ComposerCommands.js Line: 932 Error: toolbar is null Source File: chrome://editor/content/editor.js Line: 101 } (The window does open though.) 2) http://mxr.mozilla.org/comm-central/source/suite/debugQA/content/debugQAEditorOverlay.js#568 The previous command is taken from EditorNewPlaintext(), which is an uncalled function...

(In reply to comment #2) > 2) > http://mxr.mozilla.org/comm-central/source/suite/debugQA/content/debugQAEditorOverlay.js#568 > The previous command is taken from EditorNewPlaintext(), which is an uncalled > function... Tss, bit by mxr again: it _is_ called from Composer: http://mxr.mozilla.org/comm-central/search?string=EditorNewPlaintext

Comment on attachment 404536 [details] [diff] [review] (Av1) Remove (last) commented out contentAreaUtils.js include, Whitespace cleanup [Checkin: Comment 5] "approval-seamonkey2.0=?": trivial cleanup, no risk.

Comment on attachment 404536 [details] [diff] [review] (Av1) Remove (last) commented out contentAreaUtils.js include, Whitespace cleanup [Checkin: Comment 5] http://hg.mozilla.org/comm-central/rev/20927333426a

Any reason this is not resolved and marked fixed-seamonkey2.0 as well? It shows up in the "approved but not fixed" radar query...

(In reply to comment #6) Adding fixed-seamonkey2.0 to help tracking SM 2.0 release, but this bug is not fixed at all: patch A was only a cleanup step.

Serge, I suggest that you close this bug and file new bugs for any remaining issues.

Pardon me, but this patch has bitrotted.

(In reply to Edmund Wong from comment #9) > Pardon me, but this patch has bitrotted. Already checked in ;->

(In reply to Philip Chee from comment #8) > Serge, I suggest that you close this bug and file new bugs for any remaining > issues. Bug 716928.