Closed
Bug 452419
Opened 16 years ago
Closed 16 years ago
Message Header display shouldn't get the show references pref for each item of the header displayed
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0a3
People
(Reporter: standard8, Assigned: standard8)
Details
(Keywords: perf)
Attachments
(1 file)
|
(deleted),
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
I just noticed this whilst doing the inline edit card bug.
When we display a header, we loop round all the individual elements displayed and do the appropriate things to update them.
As part of that we are working out whether or not to display references - each time round the loop we are getting the value of the pref over the xpcom interface.
Its probably not going to affect us much perf wise, but we still shouldn't be doing it.
I've moved it into a pref observer (which we already have) and updating it from there. As its a hidden pref a MsgReload won't affect us much, but will update the display if something changes.
Attachment #335710 -
Flags: review?(bienvenu)
|
||
Updated•16 years ago
|
Attachment #335710 -
Flags: review?(bienvenu) → review+
|
Assignee | |
Comment 1•16 years ago
|
||
Checked in, changeset: 205:0213040b7ff1
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 2•16 years ago
|
||
Ftr, SeaMonkey read this pref in OnLoadMsgHeaderPane() too/only, but doesn't update it after that ... so I change my mind and think there is no (current) need to port this bug to SM.
No longer blocks: TB2SM
You need to log in
before you can comment on or make changes to this bug.
Description
•