Closed
Bug 453163
Opened 16 years ago
Closed 16 years ago
Investigate if domstub handles .addEventListener properly
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: smaug, Unassigned)
References
Details
event targets have two versions of .addEventListener.
One takes 3 parameters, defined in nsIDOMEventTarget, and the other one
4 parameters, defined in nsIDOMNSEventTarget.
nsDOMClassInfo handles .addEventTarget specially in nsEventReceiverSH/nsEventTargetSH::NewResolve
http://mxr.mozilla.org/mozilla-central/source/dom/src/base/nsDOMClassInfo.cpp?mark=7226,7275-7277,7321,7328-7330#7225
(The link is valid until nsDOMClassInfo.cpp changes - hg annotate doesn't provide marking.)
.addEventListener does seem handle the 4th parameter, but is that by accident?
Comment 1•16 years ago
|
||
This needs to happen before ship.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.9.1?
Comment 2•16 years ago
|
||
Sorry I didn't see this bug earlier. I understand this better now.
There's not a bug, because the quick stub is shadowed by the special method created by NewResolve. But for the same reason, the quick stub for addEventListener() is unreachable; there's no point having it. The patch in bug 453331 removes it.
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
Updated•16 years ago
|
Flags: blocking1.9.1?
You need to log in
before you can comment on or make changes to this bug.
Description
•