Closed
Bug 453179
Opened 16 years ago
Closed 16 years ago
Remove unused indices in a migration code path - not shutdown
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Right now in nsNavHistory::CleanUpOnQuit we remove two indicies on every shutdown:
"DROP INDEX IF EXISTS moz_places_titleindex"
"DROP INDEX IF EXISTS moz_annos_item_idindex"
This should be put into a migration code path. Bug 449640 modifies the schema version, which will make it for Firefox 3.1. We should use that upgrade function for this. Users of Firefox 3 should already have the field taken care of, but if someone comes from an older database version, we'll still be able to cover them.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #336949 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [has patch][needs review dietrich]
|
||
Updated•16 years ago
|
Attachment #336949 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [has patch][needs review dietrich] → [has patch][has review]
|
|
||
Updated•16 years ago
|
Summary: Remove unused indecies in a migration code path - not shutdown → Remove unused indices in a migration code path - not shutdown
|
|
Assignee | |
Comment 2•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
You need to log in
before you can comment on or make changes to this bug.
Description
•