Closed
Bug 453548
Opened 16 years ago
Closed 16 years ago
some pngsuite-ancillary reftests don't consider cHRM chunk
Categories
(Core :: Graphics: Color Management, defect)
Core
Graphics: Color Management
Tracking
()
RESOLVED
FIXED
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
PNG has a few optional chunks that do partial color management without full ICC profiles. One of these is the cHRM chunk, which contains chromaticity information. We used to ignore this information, but with color management on we instead use it to build a proper ICC profile. The reference renderings don't take these chunks into account, so they fail with color management turned on.
|
Assignee | |
Comment 1•16 years ago
|
||
Fixes for the cHRM-chunked image references. This now takes that color information into account, so these two tests will fail if color management is disabled under this patch. As such, this patch needs to be applied at the same time as the patch that turns color management on.
Attachment #336944 -
Flags: review?
|
|
Assignee | |
Updated•16 years ago
|
Attachment #336944 -
Flags: review? → review?(dolske)
|
||
Updated•16 years ago
|
Attachment #336944 -
Flags: review?(dolske) → review+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 336944 [details] [diff] [review]
test fixes
I'd suggest checking that the test passes on Windows and Linux too, let there be unexpected burnage when you check in.
|
|
Assignee | |
Comment 3•16 years ago
|
||
pushed in b0aaf69e714e
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
|
|
Assignee | |
Updated•16 years ago
|
Component: GFX → GFX: Color Management
Product: Core Graveyard → Core
QA Contact: general → color-management
You need to log in
before you can comment on or make changes to this bug.
Description
•