Closed
Bug 453867
Opened 16 years ago
Closed 16 years ago
Change NS_HILDON by MOZ_PLATFORM_HILDON
Categories
(Toolkit Graveyard :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tonikitoo, Assigned: tonikitoo)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
NS_HILDON -> MOZ_PLATFORM_HILDON
MOZ_PLATFORM_HILDON sounds more descriptive and meaningful. follow up to bug https://bugzilla.mozilla.org/show_bug.cgi?id=453384#c6
|
Assignee | |
Comment 1•16 years ago
|
||
dep to 435885 set. see https://bugzilla.mozilla.org/show_bug.cgi?id=435885#c8
Blocks: 435885
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #337384 -
Flags: superreview?
Attachment #337384 -
Flags: review?(blassey)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Attachment #337384 -
Attachment is obsolete: true
Attachment #337387 -
Flags: superreview?
Attachment #337387 -
Flags: review?(blassey)
Attachment #337384 -
Flags: superreview?
Attachment #337384 -
Flags: review?(blassey)
|
||
Comment 4•16 years ago
|
||
Comment on attachment 337387 [details] [diff] [review]
simple patch (v2) - missing ","
I'm not the right person to review these changes (ted is probably).
Also, this patch should include switching over all the current uses of NS_HILDON to MOZ_PLATFORM_HILDON.
Attachment #337387 -
Flags: superreview?
Attachment #337387 -
Flags: review?(blassey)
|
|
Assignee | |
Comment 5•16 years ago
|
||
blassey, it is not being used yet ... see http://mxr.mozilla.org/mozilla-central/search?string=ns_hildon
actually, there are some patches that use them (like vkb ones) but not checked in.
|
|
Assignee | |
Updated•16 years ago
|
Attachment #337387 -
Flags: review?(ted.mielczarek)
|
||
Updated•16 years ago
|
Attachment #337387 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•16 years ago
|
||
brad pushed.
19108:08d86121dc05
|
|
||
Comment 7•16 years ago
|
||
author Brad Lassey <blassey@mozilla.com>
Wed Sep 10 12:08:44 2008 -0400 (at Wed Sep 10 12:08:44 2008 -0400)
changeset 19108 08d86121dc05
parent 19107 853fde538b60
child 19109 fe6a1600592c
Keywords: checkin-needed
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•