Closed
Bug 453896
Opened 16 years ago
Closed 16 years ago
need to flush delayed resizes during layout flushes
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b1
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
I initially wrote this patch thinking it might fix bug 448132, but it didn't.
However, after working on bug 453759, I realized that this patch fixes a bug where a bunch of the tests in layout/style/test/test_media_queries.html fail when the test is loaded in a non-active tab, i.e., one of the following two ways:
Steps to reproduce:
1. cd objdir/_tests/testing/mochitest && python ./runtests.py --test-path=layout/style
2. right click on the "test_media_queries.html" link and select "Open in new Tab"
3. switch to the new tab
4. hit reload
5. switch back to the directory listing tab
6. right click on the test page tab and select "Reload Tab"
7. switch to the test page tab
Actual results:
3. a bunch of the tests fail (this is way-to-reproduce #1)
5. all tests pass
7. a bunch of the tests fail again (this is way-to-reproduce #2)
Expected results:
3. all tests pass
5. all tests pass
7. all tests pass
The attached patch fixes the bug, but I need to write a test that tests it.
Flags: blocking1.9.1?
Assignee | ||
Comment 1•16 years ago
|
||
Er, 3/5/7 lists in the above comment should be 3/4/7 in both cases.
Assignee | ||
Comment 2•16 years ago
|
||
This adds two tests:
* a normal mochitest that runs a part of test_media_queries.html inside an iframe in the non-visible part of a deck
* a browser mochitest that runs the same part of test_media_queries.html in a new tab
I verified that the tests pass with the patch and that 6 of the tests fail if I comment out the FlushDelayedResize call (added in this patch) in nsPresShell.cpp
Attachment #337138 -
Attachment is obsolete: true
Attachment #337497 -
Flags: superreview?(bzbarsky)
Attachment #337497 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•16 years ago
|
||
(It also wouldn't surprise me if this patch fixed some real-world bugs...)
Updated•16 years ago
|
Attachment #337497 -
Flags: superreview?(bzbarsky)
Attachment #337497 -
Flags: superreview+
Attachment #337497 -
Flags: review?(bzbarsky)
Attachment #337497 -
Flags: review+
Comment 4•16 years ago
|
||
Comment on attachment 337497 [details] [diff] [review]
patch with tests
Please rev nsIViewManager's IID, and looks good.
Assignee | ||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 6•16 years ago
|
||
Possibly caused https://bugzilla.mozilla.org/show_bug.cgi?id=454578 ??
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P3
Updated•16 years ago
|
Keywords: fixed1.9.1
Comment 7•16 years ago
|
||
pushed: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c9482d51ef47
Seeing as there hasn't been any discussions about this bug for 8 months and it's been in mochitest, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.
Comment 8•9 years ago
|
||
Comment 9•9 years ago
|
||
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
Comment 12•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•