Closed
Bug 454109
Opened 16 years ago
Closed 16 years ago
move urlbar functions to the urlbar binding
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3.1b1
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #337343 -
Flags: review?(mano)
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #337343 -
Attachment is obsolete: true
Attachment #337345 -
Flags: review?(mano)
Attachment #337343 -
Flags: review?(mano)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 337345 [details] [diff] [review]
patch, the right one
>
> function toJavaScriptConsole()
> {
> toOpenWindowByType("global:console", "chrome://global/content/console.xul");
> }
>
> function BrowserDownloadsUI()
>@@ -4888,32 +4741,27 @@ function handleLinkClick(event, href, li
> else
> openNewWindowWith(href, doc, null, false);
> event.stopPropagation();
> return true;
> }
> return false;
> }
>
>-function middleMousePaste(event)
>-{
>+function middleMousePaste(event) {
don't do that.
> var postData = { };
> url = getShortcutOrURI(url, postData);
> if (!url)
> return;
>
>- try {
>- addToUrlbarHistory(url);
>- } catch (ex) {
>- // Things may go wrong when adding url to session history,
>- // but don't let that interfere with the loading of the url.
>- }
>+ addToUrlbarHistory(url);
>
I actually prefer that any exception may be caught here, so remove the other try block instead (and please reportErrror).
r=mano otherwise..
Attachment #337345 -
Flags: review?(mano) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
You need to log in
before you can comment on or make changes to this bug.
Description
•