Closed
Bug 454426
Opened 16 years ago
Closed 16 years ago
trivial prbool stuff in /widget/*/gtk/
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #337692 -
Flags: review?(roc)
Comment on attachment 337692 [details] [diff] [review]
fixes
I prefer != 0, actually.
Attachment #337692 -
Flags: review?(roc) → review+
|
Assignee | |
Updated•16 years ago
|
Attachment #337692 -
Flags: superreview?(roc)
|
|
Assignee | |
Comment 2•16 years ago
|
||
Comment on attachment 337692 [details] [diff] [review]
fixes
We are using !! for consistency, as that seemed to be the most popular choice back in the day.
Can I get an sr on the patch too?
Attachment #337692 -
Flags: superreview?(roc) → superreview+
Comment on attachment 337692 [details] [diff] [review]
fixes
You don't need sr in widget, but sure.
Actually I'm pretty sure we use != 0 a lot more than !!. So I'd prefer != 0.
|
|
Assignee | |
Comment 4•16 years ago
|
||
pushed e717f7b0c526
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Assignee: nobody → tglek
You need to log in
before you can comment on or make changes to this bug.
Description
•