Closed
Bug 454654
Opened 16 years ago
Closed 16 years ago
Fix text attributes tests so they work on all platforms
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
On Windows, the pixel size and font family strings are different.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Attachment #337936 -
Flags: review?(surkov.alexander)
|
||
Updated•16 years ago
|
Attachment #337936 -
Flags: review?(surkov.alexander) → review+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 337936 [details] [diff] [review]
Patch
r=me but please consider another approach, it is getting font size and family from document element for example
|
|
Assignee | |
Comment 3•16 years ago
|
||
Attachment #337936 -
Attachment is obsolete: true
Attachment #338050 -
Flags: review?(surkov.alexander)
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 338050 [details] [diff] [review]
Use getComputedStyle instead.
r=me but please consider to use computedStyles for all styes and all defAttrs entries.
I think we can use computedStyles because we don't want to test styles computing here but we want to test here logic of text attributes, right?
Following this we should consider to use computed styles for defAttrs and attrs entries both.
You can keep this in mind or file following up bug or fix this here. It's up to you.
Attachment #338050 -
Flags: review?(surkov.alexander) → review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Pushed in changeset:
http://hg.mozilla.org/mozilla-central/rev/90fcd51e53c8
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•