Closed Bug 454964 Opened 16 years ago Closed 16 years ago

|make check|: test_0110_general.js reports leak 1

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Platform:
x86
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

(Blocks 1 open bug)

Details

(Keywords: memory-leak)

Attachments

(1 file)

simple patch - rev1
(deleted), patch
mconnor
: review+
beltzner
: approval1.9.1b2+
Details | Diff | Splinter Review
spinoff of Bug 449240 for app update
Per Bug 449240 comment #4 these two tests have the same report with only 1 XPCWrappedNative and 1 XPCWrappedNativeProto more.
You could try to remove _update and other properties holding XPCOM objects from the prototypes and instead declare them in the component's constructor (add |this._update = null| in |Downloader(background))|. Putting them on the prototype keeps them alive until we unload the module, which is after the last cycle collection.
The patch in bug 324121 fixes the leak in test_0030_general.js
Depends on: 324121
test_0030_general.js no longer leaks after the checkin of bug 324121. Updating summary accordingly.
Summary: |make check|: test_0030_general.js and test_0110_general.js report leak 1 → |make check|: test_0110_general.js reports leak 1
Attached patch simple patch - rev1 (deleted) — — Splinter Review
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #346549 - Flags: review?(mconnor)
Attachment #346549 - Flags: review?(mconnor) → review+
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081106 Minefield/3.1b2pre] (home, optim default) (W2Ksp4) (In reply to comment #5) > test_0030_general.js no longer leaks after the checkin of bug 324121. I confirm that this test doesn't leak (at all) anymore. (In reply to comment #6) > simple patch - rev1 I confirm that this patch fixes this test (whole) leak.
Attachment #346549 - Flags: approval1.9.1b2?
Comment on attachment 346549 [details] [diff] [review] simple patch - rev1 "approval1.9.1b2=?": Trivial leak fix, no risk.
Comment on attachment 346549 [details] [diff] [review] simple patch - rev1 a=beltzner
Attachment #346549 - Flags: approval1.9.1b2? → approval1.9.1b2+
Pushed: http://hg.mozilla.org/mozilla-central/rev/301a7a8617e6
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081114 Minefield/3.1b2pre] (home, optim default) (W2Ksp4) V.Fixed
Status: RESOLVED → VERIFIED
Keywords: mlk
Depends on: 456414
Depends on: 469523
No longer depends on: 456414
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: