Right clicking on most widgets either makes them respond or react (i.e. buttons depress visually, but onclick doesn't really fire). I don't see why this is the case, and it feels a little sloppy (what's the purpose of having them visually respond if they aren't actually functioning?) This has been the case for as long as I remember, and while I assume it's known, I just wanted to ensure that it's out there...

Yes, it is wrong, and feels sloppy, but we have no time for it. accepting for future/helpwanted.

So what would it take to fix this? Right click shouldn't fire onclick, right? Or when being right clicked upon, buttons shouldn't get in the :active state?

I think this is actually bug 30878, no?

I sure hope so (major/m21, not normal/future). Marking dup for now. *** This bug has been marked as a duplicate of 30878 ***

Marking verified (for now). ... Blake, is there some reason that this is not the same bug (you sound tenuous in your assessment -- I thought it was a straight-up dup).

Well, that original bug seems to describe more the fact that if you right click on some buttons, they actually trigger. This describes that if you right click on some buttons (or other widgets), they won't trigger, but they'll visually respond. But, judging from the dups marked of that bug, that's pretty much become what I intended through this bug.

reopening because buttons that use oncommand still change appearance onmousedown with the right mousebutton (see bug 30878), so this must be separate. hyatt, why do buttons go :active if it's the right mouse button?

For CSS2, I think :active works with any button. I think CSS3 may be adding more variation so you can control which button (with some different pseudos or something).

hmm, ok. maybe ian can confirm?

On web pages, this is WORKSFORME, so it looks like a code-level issue to me rather than a simple CSS issue...

sending to hyatt per ian's last comment

->future, per hyatt

Any ideas on where we would need to filter to left-click only? I'm very interested in fixing this.

Taking...

*** Bug 79664 has been marked as a duplicate of this bug. ***

hyatt, what did we decide here? I forget. I think we said it was okay if onclick didn't change the content to :active. If so, can you sr the second patch here?

hyatt - yes, no, maybe so?

hyatt, sr this patch or i'll come find you and beat you senseless. this isn't brain surgery.

sr=ben@netscape.com provided an ESM person looks at this too.

cc'ing saari for review. so you don't get confused like ben: basically this patch just bails early, that other stuff is just moving a block somewhere else (and changing a null check a bit).

r=kerz

a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)

r=saari

fixed.