Closed
Bug 455374
Opened 16 years ago
Closed 16 years ago
WinCE JS DLL does not need DllMain() function
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wolfe, Assigned: wolfe)
References
Details
(Keywords: mobile)
Attachments
(1 file)
|
(deleted),
patch
|
crowderbt
:
review+
|
Details | Diff | Splinter Review |
WinCE does not need a DllMain function defined in JSAPI.CPP
Attachment #338696 -
Flags: review?(doug.turner)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 338696 [details] [diff] [review]
Comment out the DllMain() function within JSAPI.cpp
wolfe, don't we need a dllmain if we were building the js library as a .dll.
Attachment #338696 -
Flags: review?(doug.turner) → review?
|
Assignee | |
Comment 2•16 years ago
|
||
Good point. As I build WinMobile XULRunner right now, the js library is included into another library -- hence two DllMain() functions butt against one another.
I should look for a flag that says I am building a LIB instead of a DLL - and do the right thing about DllMain based upon that LIB verses DLL flag.
|
||
Updated•16 years ago
|
Attachment #338696 -
Flags: review? → review+
|
||
Updated•16 years ago
|
Assignee: nobody → wolfe
|
|
||
Comment 3•16 years ago
|
||
checked in on Tue Sep 23 21:10:58 2008 -0700
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Component: General → JavaScript Engine
Product: Fennec → Core
QA Contact: general → general
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•