Closed Bug 455436 Opened 16 years ago Closed 16 years ago

XPConnect insists on using its own error reporter even when another is already set

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

Attachments

(2 files, 3 obsolete files)

Fix DOM error reporter
(deleted), patch
Details | Diff | Splinter Review
Patch, v1.2
(deleted), patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review
Attached patch Patch, v1 (obsolete) (deleted) — — Splinter Review 
This means that I can't guarantee errors are always propagated correctly from a worker to its parent. I got around this by calling my message handlers manually in the threads code but I can't do something similar for XHR. Patch attached.
Attachment #338778 - Flags: superreview?(jst)
Attachment #338778 - Flags: review?(jst)
Attachment #338778 - Attachment is patch: true
Attachment #338778 - Attachment mime type: application/octet-stream → text/plain
Attached patch Patch v1.1 (obsolete) (deleted) — — Splinter Review 
Oops, fixed XPConnect style problems.
Attachment #338778 - Attachment is obsolete: true
Attachment #338779 - Flags: superreview?(jst)
Attachment #338779 - Flags: review?(jst)
Attachment #338778 - Flags: superreview?(jst)
Attachment #338778 - Flags: review?(jst)
Attachment #338779 - Flags: superreview?(jst)
Attachment #338779 - Flags: superreview+
Attachment #338779 - Flags: review?(jst)
Attachment #338779 - Flags: review+
Attached patch Additional changes (obsolete) (deleted) — — Splinter Review 
Need to fix xpcshell's error handler so that unit tests succeed...
Attachment #340443 - Flags: superreview+
Attachment #340443 - Flags: review+
Attached patch Fix DOM error reporter (deleted) — — Splinter Review 
Bah, gotta fix the DOM error reporter to ignore inner frame exceptions also, otherwise mochitests fail all over the place :(
Attached patch Patch, v1.2 (deleted) — — Splinter Review 
This is a rollup of all previous patches.
Attachment #338779 - Attachment is obsolete: true
Attachment #340443 - Attachment is obsolete: true
Attachment #340659 - Flags: superreview?(jst)
Attachment #340659 - Flags: review?(jst)
Attachment #340659 - Flags: superreview?(jst)
Attachment #340659 - Flags: superreview+
Attachment #340659 - Flags: review?(jst)
Attachment #340659 - Flags: review+
Pushed changeset 3aec0eec68a1 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Depends on: 460569
Depends on: 466538
Depends on: 489671
This broke reporting of JS errors in event handlers.  See bug 489671.
Depends on: 502718
Depends on: 503244
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: